Repository navigation
feat(flutter): identify Dart snapshot builds and inspect AOT payloads by pure APK parsing #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
03d2eaf
feat(flutter): identify Dart snapshot builds by pure APK parsing
2945f50
feat(flutter): inspect Dart AOT snapshots through the ELF symbol table
ddf1269
fix(flutter): own snapshots, bound image reads, and preserve cancella…
349b212
docs(flutter): cover the Italian README with the Flutter row
b8cbea9
fix(flutter): make the ABI pattern portable for v-mode validators
e12bfbf
refactor(flutter): reuse shared harnesses and deduplicate the vertical
2207cc6
fix(flutter): address review findings from real-app verification
93db928
fix(flutter): address the Codex review findings
eeb56f9
fix(flutter): address the second Codex review round
87ac338
fix(flutter): address the third Codex review round
24d61ec
fix(flutter): address rounds three and four of the Codex review
802bb9b
fix(flutter): address the fifth Codex review round
9603ecb
fix(flutter): address the sixth Codex review round
ef79672
fix(flutter): address the seventh Codex review round
8d9fd5b
fix(flutter): address the eighth Codex review round
dbdd7fc
fix(flutter): harden streaming, sizes, and cancellation after self-re…
c6e7325
fix(flutter): require structurally parseable ELF headers for complete…
cf18c8c
fix(flutter): validate ELF and snapshot coverage
61394b6
fix(flutter): resolve review findings and CI effect checks
248ce4c
chore(flutter): resolve upstream effects-audit conflict
8b88190
chore: merge main into Flutter analysis branch
morluto 34e764d
fix(flutter): unify artifact ownership and bound ELF evidence
morluto 98707b4
chore: merge latest main into Flutter analysis branch
morluto 9089b98
fix(flutter): preserve ELF provenance and partial coverage
morluto ccfaec0
chore: merge latest main after documentation updates
morluto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(flutter): address the Codex review findings
Eight findings, all applied: - P1: SnapshotHashScanner keeps candidates in a Set (no quadratic Array.includes) with a 64-distinct-hash cap, so a hostile payload of magic+hash records cannot stall the scan or bloat the response. - P1: projectStringPool stops admitting new distinct entries once each category reaches twice its projection bound and reports collectionCapped; allocation and sorting now track the response, not the payload. - P2: ZIP reader rejections during entry iteration or entry streaming map into the typed error algebra (cancellation vs input refusal) instead of escaping as unhandled exceptions in both operations. - P2: magic_valid now marks coverage only for the *Data symbols; a complete four-symbol image with valid data magics reports complete coverage (the instruction symbols intentionally lack the magic). - P2: the MCP server closes the Flutter provider during shutdown, so a retained snapshot root is retried and reported, not leaked. - P2: LabeledStringScanner commits matches only when a printable run is delimiter-terminated; the carry grows to 600 bytes so a 500-character toolchain line survives any chunk boundary untruncated. - P2: both Flutter tool effects declare writesFilesystem: true; the owned APK snapshot and extracted libapp.so are temporary writes. - P2: the verify lane asserts every ABI agrees on exactly one snapshot hash instead of discarding the computed set.
- Loading branch information
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.