Repository navigation
test(ci): stabilize JADX recovery and ignore generated reports - #1668
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
TL;DR: I could not make the flaky test fail on Linux, before or after this change. All 178 runs of the JADX test file passed, 33 of 33 tests each time. So I have no proof the retry fixes anything here, and the change did no harm. ResultsEach run is
Not run
Thanks, Y0UW1SH, for the focused fix and the clear description. Test setup🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
|
Appreciate the targeted CI cleanup, @Y0UW1SH. Your bounded retry lets the JADX recovery fixture verify eventual owner cleanup through snapshot churn, and ignoring |
Summary
Stabilize the synthetic JADX cleanup-recovery test and keep generated Vitest blob reports out of source formatting.
These two CI fixes were verified during #1612 maintenance. That browser proposal remains closed following the maintainer's #1608 scope decision. The runtime catalog/deadline fixes are already proposed in #1363.
Problem and expected behavior
After the injected ownership-verification failure clears, the child can move between live and exited snapshots. A single immediate close can reject while the retained cleanup owner can still recover. Require verified cleanup within a bounded recovery window.
Vitest writes generated JSON into
.vitest/blob/; source formatting should ignore those reports alongside existing coverage and report directories.Change and scope
provider.close()for at most five seconds only during the test's intentional recovery and final teardown. Preserve the initial shared failure, retained workspace, verified process/workspace removal, and single-launch assertions..vitest/to.gitignore.Exactly two files change: +11/-4. Head:
5226656a2f550c3a40503ab5cfdf03706fa1b371; branch parent:7bb4ac219c16884fcadd946eed4015ace2a2419f; verified tree:891b3e099bbf3a965fa601782538e9b6bca7e5e5.Contract and boundary impact
Evidence and regression coverage
8451051a4fd5f84e042e1bd655c92150abb7f3feagainst upstream79569349651b5089f04d466b955f5f1ac59a6a1d.psprevents owned-process tests from launching; the fresh GitHub-hosted suite provides that verification. These JADX tests use the repository's synthetic MCP fixture, not a real JADX engine.Validation performed
npm run check:ci— 8/8 tasks and architecture guards passed across 1,101 source files; duplication 2.45% under the unchanged 2.6% gate. A cold parallel run hit the container memory limit; isolated typechecking passed, then the normal command passed.npm run build:cached— 3/3 tasks passed.npm run docs:check— 6/6 tasks passed.git diff --check, and independent review of the final two-file diff passed.Compatibility, safety, and release
f88c99021b88ce67e513025901f57478d8107d0c: the JADX provider/test and report ignore paths are unchanged, and the shared process-identity extension preserves existing calls.Review checklist
Published in draft and promoted only after the fresh full CI run passed. Ready for review; unmerged.