Skip to content

fix(artifacts): preserve emitted ZIP entry identity - #1726

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/zip-member-identity-1725
Oct 11, 2026
Merged

N0zoM1z0 merged 1 commit into
mainfrom
fix/zip-member-identity-1725

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

Duplicate ZIP filenames could overwrite the source lookup for an already emitted entry, so a delayed read of the first member returned the later member’s bytes. Reject exact duplicate names in the reader before replacing that mapping. Detection is scoped to each enumeration, preserving replay and case-distinct entries; public inventory/extraction keeps its path-collision policy.

Closes #1725. Related: #1480.

Validation: reproduced on fresh main with a 218-byte real ZIP, then observed the new boundary regression fail and pass. All 28 focused ZIP/inventory/order/cancellation tests pass. Fresh compiled producer probes preserve the first member after rejection; actual CLI and stdio MCP preserve complete control results and return the duplicate-path failure, with subsequent ping/close working. Single-threaded compile/typecheck, full lint, and architecture guards pass under the local CPU/RSS limits. No external native-provider claim.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T06:17:28.805706Z 8872832 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@N0zoM1z0
N0zoM1z0 merged commit e36c82b into main Oct 11, 2026
31 checks passed
@N0zoM1z0
N0zoM1z0 deleted the fix/zip-member-identity-1725 branch October 11, 2026 06:25
@morluto morluto mentioned this pull request Oct 13, 2026
3 tasks done
@morluto morluto added bug Something isn't working area: evidence Evidence, artifacts, and reconstruction labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: evidence Evidence, artifacts, and reconstruction bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(artifacts): duplicate ZIP members overwrite emitted entry identity

2 participants