Skip to content

fix(process): aggregate incomplete trace-spec diagnostics - #1756

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/trace-spec-diagnostics-1753
Oct 11, 2026
Merged

N0zoM1z0 merged 1 commit into
mainfrom
fix/trace-spec-diagnostics-1753

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

An 18 KB incomplete partial-order trace specification currently creates 19,900 near-identical diagnostics: 2,625,117 CLI output bytes and 1,629,885 MCP text bytes. Summarize this violated invariant once with its exact missing-pair count and first undeclared pair. Keep the existing message for one missing pair, scan all pairs, and preserve the other validation errors.

Remove suffix-array copies from both pair scans and replace per-pair two-element sorting with equivalent lexical key construction. No event/input cap or result truncation is introduced.

Closes #1753.

Validation:

  • Reproduced through freshly built latest main 062723e44e937c1e1df865e9ae16184b41e70ae8, then repeated actual public CLI and SDK stdio MCP workflows after the fix. The same invalid input returns 467 CLI bytes / 185 MCP text bytes, one issue, exact count 19,900, and the server answers a subsequent ping.
  • 12 domain regressions and 6 MCP boundary regressions pass, including transitive/not-before/unordered coverage, singleton compatibility, reversed duplicate declarations, valid Evidence parity and invalid CLI/MCP diagnostics.
  • A valid 1,200-event unordered control returns exactly the same complete authenticated Evidence, identity and CLI/MCP text/structured result as the baseline. Whole Evidence SHA-256: c3edab6bb0da15eb4bcc44f56cfb8739cb56789c6020ffa0267cfa46cafb04c8.
  • Flameox 0.2.9 profiles the actual complete CLI process before and after with the same 1,200-event input; full captured stdout SHA-256 is identical. Pair-key sorting was a resolved baseline hotspot and no longer appears in the leading fixed hotspots. These are single controlled profiles, not a portable throughput percentage or token-count measurement.
  • Full single-threaded typecheck, lint/module boundaries, changed-file format check, architecture guards and diff check pass. All steps stay below the 2 GiB process-family budget; the temporary Flameox environment has been removed and native profiles retained privately.

Capture inputs use authenticated EMPTY_PROCESS_CAPTURE_EXAMPLE fixture Evidence. No live process capture, installed native provider, browser, Notion or Obsidian verification is claimed. Tool input schemas and successful result contracts are unchanged; missing-pair error multiplicity is intentionally reduced.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T07:52:10.330037Z 474ced7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@N0zoM1z0
N0zoM1z0 merged commit 857a1b7 into main Oct 11, 2026
31 checks passed
@N0zoM1z0
N0zoM1z0 deleted the fix/trace-spec-diagnostics-1753 branch October 11, 2026 08:04
@morluto morluto mentioned this pull request Oct 13, 2026
3 tasks done
@morluto morluto added bug Something isn't working area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(process): aggregate quadratic trace-specification diagnostics

2 participants