Repository navigation
fix(process): aggregate incomplete trace-spec diagnostics - #1756
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An 18 KB incomplete partial-order trace specification currently creates 19,900 near-identical diagnostics: 2,625,117 CLI output bytes and 1,629,885 MCP text bytes. Summarize this violated invariant once with its exact missing-pair count and first undeclared pair. Keep the existing message for one missing pair, scan all pairs, and preserve the other validation errors.
Remove suffix-array copies from both pair scans and replace per-pair two-element sorting with equivalent lexical key construction. No event/input cap or result truncation is introduced.
Closes #1753.
Validation:
062723e44e937c1e1df865e9ae16184b41e70ae8, then repeated actual public CLI and SDK stdio MCP workflows after the fix. The same invalid input returns 467 CLI bytes / 185 MCP text bytes, one issue, exact count 19,900, and the server answers a subsequent ping.c3edab6bb0da15eb4bcc44f56cfb8739cb56789c6020ffa0267cfa46cafb04c8.Capture inputs use authenticated
EMPTY_PROCESS_CAPTURE_EXAMPLEfixture Evidence. No live process capture, installed native provider, browser, Notion or Obsidian verification is claimed. Tool input schemas and successful result contracts are unchanged; missing-pair error multiplicity is intentionally reduced.