Repository navigation
fix(ida): declare GUI navigation for attached legacy analysis - #1764
Merged
Merged
Conversation
Attached IDA mode always uses the legacy 1.4 producer, whose disassemble_function jumps to the function and whose decompile_function opens or reuses a pseudocode view whenever an IDA window is active. Session discovery still advertised may_show_ui: false for every operation. Declare the UI effect for the attached operations that reach those tools: pseudocode, assembly, raw function instructions and the function dossier. Headless operations and the other attached operations keep false. A conformance check now compares each declaration with the upstream tools the operation actually calls. Fixes #1712 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712.
Problem
Attached IDA mode always selects the legacy 1.4 producer (
mrexodia/ida-pro-mcptag 1.4.0,27722e9). When an IDA Qt window is active, that producer has two GUI side effects:disassemble_functioncallsida_kernwin.jumpto(start)(mcp-plugin.py:939-940).decompile_functioncallsida_hexrays.open_pseudocode(start, OPF_REUSE)(mcp-plugin.py:877-878).No other legacy tool REA uses touches the GUI. But
idaCapabilitieshard-codedmayShowUi: false, sobinary_sessionreportedeffects.may_show_ui: falsefor operations that move the analyst's view.Change
In attached mode, the operations that reach those tools now declare
mayShowUi: true:procedure_pseudo_codeprocedure_assemblyread_function_instructions: this one also callsdisassemble_function, which the issue did not list.analyze_functionHeadless mode and the other attached operations keep
false. The issue asked to keep these controls.docs/ida-provider.mdnow describes the side effect in the attached section. The coverage note now says that requested GUI navigation is out of scope, so it no longer contradicts the side effect.Validation
tests/conformance/ida/providerContracts.test.ts, run for both attached and headless modes on every operation. It runs the operation throughIdaSessionClientagainst the recording producer and asserts that the declaredmayShowUiequals whether the operation calleddisassemble_functionordecompile_function. Without the source change it fails on the four attached operations listed above.npm run test:local -- tests/conformance/ida/providerContracts.test.ts tests/composition/idaProvider.test.ts src/ida/*.test.tspasses (86 tests).npm run test:focusedon the session and provider-selection MCP/composition tests passes (39 tests).npm run check:fastandnpm run docs:checkpass.Not verified: a live IDA GUI. The producer behavior comes from reading the pinned upstream source; no real window change was observed.
🤖 Generated with Claude Code