Skip to content

fix(ida): declare GUI navigation for attached legacy analysis - #1764

Merged
kaoru0822-kitauji merged 1 commit into
mainfrom
fix/ida-legacy-ui-effects
Oct 11, 2026
Merged

kaoru0822-kitauji merged 1 commit into
mainfrom
fix/ida-legacy-ui-effects

Conversation

@kaoru0822-kitauji

Copy link
Copy Markdown
Collaborator

Fixes #1712.

Problem

Attached IDA mode always selects the legacy 1.4 producer (mrexodia/ida-pro-mcp tag 1.4.0, 27722e9). When an IDA Qt window is active, that producer has two GUI side effects:

  • disassemble_function calls ida_kernwin.jumpto(start) (mcp-plugin.py:939-940).
  • decompile_function calls ida_hexrays.open_pseudocode(start, OPF_REUSE) (mcp-plugin.py:877-878).

No other legacy tool REA uses touches the GUI. But idaCapabilities hard-coded mayShowUi: false, so binary_session reported effects.may_show_ui: false for operations that move the analyst's view.

Change

In attached mode, the operations that reach those tools now declare mayShowUi: true:

  • procedure_pseudo_code
  • procedure_assembly
  • read_function_instructions: this one also calls disassemble_function, which the issue did not list.
  • analyze_function

Headless mode and the other attached operations keep false. The issue asked to keep these controls.

docs/ida-provider.md now describes the side effect in the attached section. The coverage note now says that requested GUI navigation is out of scope, so it no longer contradicts the side effect.

Validation

  • New conformance check in tests/conformance/ida/providerContracts.test.ts, run for both attached and headless modes on every operation. It runs the operation through IdaSessionClient against the recording producer and asserts that the declared mayShowUi equals whether the operation called disassemble_function or decompile_function. Without the source change it fails on the four attached operations listed above.
  • npm run test:local -- tests/conformance/ida/providerContracts.test.ts tests/composition/idaProvider.test.ts src/ida/*.test.ts passes (86 tests).
  • npm run test:focused on the session and provider-selection MCP/composition tests passes (39 tests).
  • npm run check:fast and npm run docs:check pass.

Not verified: a live IDA GUI. The producer behavior comes from reading the pinned upstream source; no real window change was observed.

🤖 Generated with Claude Code

Attached IDA mode always uses the legacy 1.4 producer, whose
disassemble_function jumps to the function and whose decompile_function
opens or reuses a pseudocode view whenever an IDA window is active.
Session discovery still advertised may_show_ui: false for every
operation.

Declare the UI effect for the attached operations that reach those
tools: pseudocode, assembly, raw function instructions and the function
dossier. Headless operations and the other attached operations keep
false. A conformance check now compares each declaration with the
upstream tools the operation actually calls.

Fixes #1712

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T08:17:54.268690Z 1997795 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kaoru0822-kitauji
kaoru0822-kitauji merged commit cf69207 into main Oct 11, 2026
31 checks passed
@kaoru0822-kitauji
kaoru0822-kitauji deleted the fix/ida-legacy-ui-effects branch October 11, 2026 08:36
@github-actions github-actions Bot mentioned this pull request Oct 11, 2026
3 tasks done
@morluto morluto added bug Something isn't working area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Attached IDA analysis reports no UI effects despite legacy GUI actions

2 participants