Repository navigation
perf(mcp): reduce Windows startup module resolution - #1814
Merged
Merged
Conversation
N0zoM1z0
marked this pull request as ready for review
October 11, 2026 13:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows MCP initialization can exceed the SDK’s default 60-second deadline. The Windows trace investigated in #1685 showed substantial module filesystem resolution.
Bundle REA’s internal MCP modules and route the packaged dispatcher to that entrypoint. Dependencies remain external and dynamic imports remain lazy. Original compiled files stay available to CLI and worker entrypoints; bundled code retains their module URLs for resources, native helpers and package resolution. Unsupported import metadata fails during the build.
Verified at
2bc0dfad7, based on maincdd9fe716:These are two observed pairs, not a stable latency estimate. Fresh processes used Node 24.18.0, SDK 2.3.1, two CPUs, BelowNormal priority and the unchanged 60-second initialization deadline. All four returned the same 171-tool catalog (1,967,836 bytes, identical SHA-256). First-call client validator compilation remains a separate cost.
Actual offline Windows installation completed through a guarded
npm installrepair after the boundednpm ciattempt expired. Every installed REA file matches its archive: 1,184 baseline files and 1,251 candidate files. Both packages pass normal SDK session, JavaScript worker analysis and subsequent ping; the full normalized analysis result and Evidence ID match, inputs stay unchanged and owned runtime files/processes are cleaned up. Linux passes the same public workflow. This does not verify Ghidra cold analysis or establish a memory improvement.build:cached, normalnpm pack/prepack, four process/dispatcher regression cases,check:fast, lint and docs checks pass under the 2,304 MiB family limit. Full local typechecking uses the compiler’s single-threaded mode. All 31 exact-head CI checks pass, including native package baselines.Refs #1685.