Repository navigation
fix(windows): retain failed native inspection ownership - #1826
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5616c6cb48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: .cache/windows-native-inspection-fixture/ | ||
| if-no-files-found: error |
There was a problem hiding this comment.
Upload the fixture from a non-hidden path
When the windows-native-build job runs, actions/upload-artifact@v4 excludes this entire artifact because every file is under the dot-prefixed .cache directory. The action's official documentation defines files inside dot-prefixed folders as hidden and excludes them by default; consequently if-no-files-found: error fails the build before the production artifact is uploaded, and the downstream Windows conformance check never runs. Move the fixture outside .cache or set include-hidden-files: true after validating its contents.
AGENTS.md reference: AGENTS.md:L44-L44
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5616c6cb48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: windows-native-inspection-fixture | ||
| path: .cache/windows-native-inspection-fixture/ |
There was a problem hiding this comment.
Include hidden fixture files in the artifact upload
In the windows-native-build job, the entire upload path is beneath .cache, but actions/upload-artifact@v4 excludes hidden files by default; its documentation explicitly treats files within dot-prefixed folders as hidden. Consequently this upload finds no files and, with if-no-files-found: error, fails every runtime/full CI run before windows-curated can execute the new verifier. Add include-hidden-files: true, as the nearby .turbo upload does, or emit the fixture outside .cache.
Useful? React with 👍 / 👎.
Native inspection discarded its probe owner when directory cleanup failed, leaving an unprotected directory and permanently caching the failed availability result. Retain that owner per Node environment, settle its cleanup before admitting another probe, and let a later availability query retry native invocation failures. Successful admission and static artifact failures remain cached.
Register cleanup ownership before exposing callbacks; environment teardown makes a final attempt and reports persistent failures with reversible path diagnostics. There is no blocking sleep or backoff.
Refs #1701. The original intermittent Win32 5 host cause remains unproven; this repairs the independently reproduced ownership/cache defect and does not close that investigation.
Validation:
.cache, tests it on Windows, and independently verifies the production addon. Pack dry run excludes the injected fixture.Resource scope: Flameox supervised compilation and source checks. Default
check:fastexceeded the 1.81 GiB capture limit; single-threaded typecheck and the separate lint/tests passed. V8 launcher profiles do not establish child compiler CPU hotspots. Windows Ghidra/JDK and macOS/saved Hopper documents were not verified by this PR.