Skip to content

fix(windows): retain failed native inspection ownership - #1826

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/windows-native-authority-1701-20261011
Oct 11, 2026
Merged

N0zoM1z0 merged 1 commit into
mainfrom
fix/windows-native-authority-1701-20261011

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

Native inspection discarded its probe owner when directory cleanup failed, leaving an unprotected directory and permanently caching the failed availability result. Retain that owner per Node environment, settle its cleanup before admitting another probe, and let a later availability query retry native invocation failures. Successful admission and static artifact failures remain cached.

Register cleanup ownership before exposing callbacks; environment teardown makes a final attempt and reports persistent failures with reversible path diagnostics. There is no blocking sleep or backoff.

Refs #1701. The original intermittent Win32 5 host cause remains unproven; this repairs the independently reproduced ownership/cache defect and does not close that investigation.

Validation:

  • Real Windows 11 x64, Node 24.18.0, NTFS: the old inspector loses ownership under a controlled first disposition failure; the candidate retains the rename-blocking handle, recovers on a later query, caches successful admission, and cleans the pending probe on normal environment teardown.
  • Real production-addon native conformance and small JavaScript CLI/MCP workflows, including complete Evidence validation, source digest verification, normalized-result parity, and empty private temporary directories.
  • 29 source tests; single-threaded typecheck, lint/module boundaries, touched-file format check, artifact metadata/digest/PE validation, and pack dry run.
  • CI builds the injected artifact separately under .cache, tests it on Windows, and independently verifies the production addon. Pack dry run excludes the injected fixture.

Resource scope: Flameox supervised compilation and source checks. Default check:fast exceeded the 1.81 GiB capture limit; single-threaded typecheck and the separate lint/tests passed. V8 launcher profiles do not establish child compiler CPU hotspots. Windows Ghidra/JDK and macOS/saved Hopper documents were not verified by this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T13:11:18.682644Z 5616c6c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5616c6cb48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment on lines +312 to +313
path: .cache/windows-native-inspection-fixture/
if-no-files-found: error

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Upload the fixture from a non-hidden path

When the windows-native-build job runs, actions/upload-artifact@v4 excludes this entire artifact because every file is under the dot-prefixed .cache directory. The action's official documentation defines files inside dot-prefixed folders as hidden and excludes them by default; consequently if-no-files-found: error fails the build before the production artifact is uploaded, and the downstream Windows conformance check never runs. Move the fixture outside .cache or set include-hidden-files: true after validating its contents.

AGENTS.md reference: AGENTS.md:L44-L44

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5616c6cb48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
- uses: actions/upload-artifact@v4
with:
name: windows-native-inspection-fixture
path: .cache/windows-native-inspection-fixture/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include hidden fixture files in the artifact upload

In the windows-native-build job, the entire upload path is beneath .cache, but actions/upload-artifact@v4 excludes hidden files by default; its documentation explicitly treats files within dot-prefixed folders as hidden. Consequently this upload finds no files and, with if-no-files-found: error, fails every runtime/full CI run before windows-curated can execute the new verifier. Add include-hidden-files: true, as the nearby .turbo upload does, or emit the fixture outside .cache.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants