Repository navigation
fix(javascript): report available parent result budget in coverage limits - #1915
Conversation
The parent reserved 80% of its result budget for future static facts whenever any source remained, so one tiny later file could discard an earlier file's completed semantic graph. Reserve at most one bounded static checkpoint's retained size per remaining source, within the same shared pool, so many remaining sources keep the previous protection. Parent-budget rejections now report the effective admission budget and explain that the CLI/MCP process heap, not max_heap_mb, bounds them. Refs #1911 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24bf9dfeac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…aware Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7f43afaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74472dacba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-static-reserve # Conflicts: # src/javascript/analysis/JavaScriptAnalysisWorker.ts
Summary
Follow-up to #1921, which fixed #1911.
This PR began as a separate fix for #1911. #1921 merged in the meantime with a more complete fix for the same code, so I resolved the merge conflict by taking
main'sJavaScriptAnalysisWorker. I also dropped my CLI regression test, because #1921'stests/acceptance/applications/javascriptCheckpointReserveCli.test.tscovers the same one-remaining-source case.What remains is a small gap in #1921. Parent-budget rejections now report
parent_available_result_budget_bytes, butjavaScriptAnalysisCoverageLimitsonly projects allowlisted limit keys. So the effective available budget appeared in the error details but never in the application coverage limits. This adds it asjavascript_analysis_parent_available_result_budget_bytes, next to the existing totalparent_result_budget_bytes.Validation
javascript_analysis_parent_available_result_budget_bytes.javascriptCheckpointReserveCli.test.tspasses on this branch (3 tests).npm run check:fastpasses.🤖 Generated with Claude Code