Skip to content

fix(javascript): report available parent result budget in coverage limits - #1915

Merged
morluto merged 6 commits into
mainfrom
fix/javascript-parent-static-reserve
Oct 11, 2026
Merged

morluto merged 6 commits into
mainfrom
fix/javascript-parent-static-reserve

Conversation

@kaoru0822-kitauji

@kaoru0822-kitauji kaoru0822-kitauji commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #1921, which fixed #1911.

This PR began as a separate fix for #1911. #1921 merged in the meantime with a more complete fix for the same code, so I resolved the merge conflict by taking main's JavaScriptAnalysisWorker. I also dropped my CLI regression test, because #1921's tests/acceptance/applications/javascriptCheckpointReserveCli.test.ts covers the same one-remaining-source case.

What remains is a small gap in #1921. Parent-budget rejections now report parent_available_result_budget_bytes, but javaScriptAnalysisCoverageLimits only projects allowlisted limit keys. So the effective available budget appeared in the error details but never in the application coverage limits. This adds it as javascript_analysis_parent_available_result_budget_bytes, next to the existing total parent_result_budget_bytes.

Validation

  • I reran a parent-budget rejection through the real CLI: an enlarged single-module input with a 448 MiB parent heap. Coverage limits now include javascript_analysis_parent_available_result_budget_bytes.
  • fix(javascript): preserve graphs within parent capacity #1921's javascriptCheckpointReserveCli.test.ts passes on this branch (3 tests).
  • npm run check:fast passes.

🤖 Generated with Claude Code

The parent reserved 80% of its result budget for future static facts
whenever any source remained, so one tiny later file could discard an
earlier file's completed semantic graph. Reserve at most one bounded
static checkpoint's retained size per remaining source, within the same
shared pool, so many remaining sources keep the previous protection.
Parent-budget rejections now report the effective admission budget and
explain that the CLI/MCP process heap, not max_heap_mb, bounds them.

Refs #1911

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T18:26:34.730982Z f18c65a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24bf9dfeac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b7f43afaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74472dacba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kaoru0822-kitauji and others added 2 commits October 11, 2026 18:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-static-reserve

# Conflicts:
#	src/javascript/analysis/JavaScriptAnalysisWorker.ts
@kaoru0822-kitauji kaoru0822-kitauji changed the title fix(javascript): size the future static reserve by remaining sources fix(javascript): report available parent result budget in coverage limits Oct 11, 2026
@morluto
morluto merged commit 72489a9 into main Oct 11, 2026
28 checks passed
@morluto
morluto deleted the fix/javascript-parent-static-reserve branch October 11, 2026 18:43
@github-actions github-actions Bot mentioned this pull request Oct 11, 2026
3 tasks done
@morluto morluto added bug Something isn't working area: domain Domain logic, errors, and pure functions labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: domain Domain logic, errors, and pure functions bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] JavaScript admission reserves 80% of parent capacity for any later file

2 participants