Repository navigation
test(http3): add real MITM capture verification lab - #1997
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
baron
left a comment
There was a problem hiding this comment.
Exact-head review: 891c787. No confirmed source defect in the bounded development-only loopback capture lab; this is an evidence hold, not a request to broaden or redesign the supported capability.
Before merging, please make the nonsecret exact-head live report/manifest, source/capture digests, and final cleanup receipts reviewable. The description pins run 41849ea4-7b4a-4fb3-93f4-d583d99ff812 and inspect-existing run 80dc2ec6-2ae1-45c7-bfef-296ceedb5947, but the reported local export was unavailable to our review. Green CI and the three safe verifier regression checks do not independently establish those real-traffic claims. No real interception, trust changes, or client configuration was performed by this review.
|
Thanks, @baron — agreed that CI and verifier regressions do not independently establish the live-traffic claims. The retained nonsecret reports, manifests, digests and cleanup receipts are available here: retained evidence package. This publishes existing evidence; no new traffic run or independent provider rerun is claimed. All artifacts refer to source
SHA-256: The original full export remains local; the linked publication is a documented subset. Captures, certificates, private keys, proxy configuration, VM disks and binaries are excluded. Full CLI/MCP replies and session bundles also remain local because they embed generated public certificates; the original export manifest lists their digests but does not make those files available. Digests establish artifact identity, not independent execution attestation. Cleanup receipts describe the recorded processes and observation times, not a general containment guarantee. All coverage limits in the PR description remain in force: native captures, Linux reverse mode, QUIC v1 and the named clients/versions only. Please keep the evidence hold until you have reviewed these artifacts; this response does not claim your acceptance. |
|
@greptileai review |
|
|
CI follow-up: the five failures in run 38379313793 reproduce identically on the historical base and exact PR merge (45 pass / 5 fail each), before the HTTP/3 marker correction can affect them. Updated this branch with upstream The exact published tree passes 50 focused release/dylib tests, 7 HTTP/3 lifecycle regressions, 120 CI planning tests, typecheck/lint, and pre-push checks on the pinned toolchain. Fresh CI is pending; existing native HTTP/3 evidence remains tied to its original tested revision. |
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Problem and scope
REA can inspect native mitmproxy captures, but the existing capture verifier does not establish that traffic negotiated HTTP/3 through a MITM. A successful HTTP request may fall back to another protocol.
This PR adds an optional, reproducible Linux reverse-proxy laboratory using existing mitmproxy and aioquic implementations. It changes no production contracts or adapters. The ten changed files comprise the nine laboratory/guide files and one optional npm command,
verify:web:http3; no HTTP/3 CI lane is added. Registering the command also resolves Knip's unused-verifier/export findings.Two scenarios
--http3-onlysmoke request. Responses are dispatched in reverse origin completion order; association is verified independently of client/capture arrival order.--http3negotiates client HTTP/2 over TCP and reaches an HTTP/1.1 TLS origin. The same positive HTTP/3 assertion must reject this capture.The positive case checks both legs' HTTP versions, transport, ALPN and TLS observations; endpoint-negotiated QUIC v1; native UUID preservation; request/response bytes, lengths and SHA-256; method, URL components and ordered duplicate regular headers; CLI/MCP parity; advertised schemas; and complete retained MCP Evidence. Both input captures must remain unchanged. Endpoint stream IDs remain scoped observations: no mitmproxy stream IDs or cross-leg mapping are invented.
UUID-specific reports and an atomic running/passed/failed marker prevent stale successes. Cleanup attempts all closes and audits while preserving the primary failure; success is published only after cleanup.
Reproduction
Follow the laboratory guide at the verified commit in a disposable Linux VM. It pins the image and mitmproxy archive by digest, cURL's HTTP/3 dependency profile and the Python runtime graph. Build from this checkout using its pinned Node/npm and locked dependencies; keep host directories unmounted and host trust/routes/packages unchanged. Before loopback traffic, ensure the guest has no IPv4 or IPv6 default route. The verified VM used IPv6 disabled in QEMU and removed its IPv4 default route. Clients/proxy receive explicit paths to generated test CAs.
The guide provides the Node/Python regression commands. Generated evidence and private keys stay outside Git. This PR publishes source and reviewed synthetic-result summaries, with no captures, certificates, VM disks or credentials attached.
Exact source and executed verification
Verified source:
891c7878dfd659437ba3c15799ef1d95abe3279c, based on upstream maine9fe6437a7da381f0aa5aa77571dcf03317122e7. Its locally retainedgit archive --format=tar.gzsource has SHA-2561942bc7d7f2180ddbddb074fea6466a21f18e7e42b983985a0fc20169a9dddd1. All 2,879 archived file digests matched the isolated worktree. Source bytes were compared inside the guest before execution and checked again afterward; the runtime was built inside the guest.The exercised guest used Node 24.18.0 / npm 11.16.0, fixture Python 3.14.7, aioquic 1.2.0, cURL 8.22.0 (OpenSSL 3.6.4, ngtcp2 1.25.0, nghttp3 1.18.0), and standalone mitmproxy 12.2.3 (bundled Python 3.14.0 / OpenSSL 3.5.5).
On this source:
npm run check, including Knip, passed locally. Guestnpm ci,npm run build:cached, and Pythonpip checkpassed.npm run verify:web:http3: fresh real traffic passed with four HTTP/3 flows and one fallback flow, CLI/MCP byte/association/schema/session checks and empty owned proxy groups. Run UUID:41849ea4-7b4a-4fb3-93f4-d583d99ff812.npm run verify:web:http3 -- ... --inspect-existingpassed: UUID80dc2ec6-2ae1-45c7-bfef-296ceedb5947. Final source hashes matched, the final laboratory process snapshot was empty, and the guest shut down cleanly.The reviewed local evidence export has SHA-256
c40d80b123d573f35c993950da8407557f698e92fabb520ad030a392467141a5; every manifest digest was checked. It excludes PEM files, private keys and proxy configuration and is not attached. Another session reviewed reports and source digests, without independently rerunning the lab or exhaustively auditing every artifact.Earlier real-provider results on production base
12ee785e5e61132898adecf9424ce6706a2e754aremain separately retained; they are not substituted for the new run. Earlier build/docs/discovery and 94 focused capture tests ran on PR head20f763775fbc87b1fc752998ba930657495dbba7; CI for the new head is tracked separately in GitHub checks. The prior APPROVED review refers to that earlier head. The full local suite /check:prwas not rerun.Coverage limits
This verifies only native captures, Linux reverse mode, QUIC v1 and the named clients/versions; it does not establish general HTTP/3 support in REA. Empty/absent/incomplete/redacted bodies, cancellations, resets, certificate failures, malformed/truncated captures, HAR, qlog, local/WireGuard modes, browsers, QUIC v2, migration, 0-RTT, mTLS, replay, sustained load and loss tolerance remain outside this increment.
Future options are being discussed separately in Discussion #2000, related to #774. They do not expand this PR or commit to future delivery.
Concurrent verification marker correction
Commit
8b92214ae567949227697007b9343a3cfcd5775afixes the race reported in review comment. Attempt registration and current-owner check/replacement share a SQLite exclusive transaction lock. Only the most recently registered attempt may publish the current marker; earlier attempts retain their own reports and diagnostics.Validation on the unchanged reviewed patch: seven lifecycle tests pass, including separate supervised processes finishing in reverse order, lock contention and lock release after an invalid marker.
npm run check,npm run docs:check, targeted strict lint and the pre-push gate passed. The lock has no global wait deadline; a live stalled owner may delay publication until it exits. This is verifier bookkeeping only. Earlier real HTTP/3 evidence remains pinned to891c7878dfd659437ba3c15799ef1d95abe3279c; no real-traffic rerun is claimed for the new commit. Fresh CI is pending.CI baseline corrections (2026-10-13)
Run 38379313793 tested merge
4f726317d7f58c05ef6e91d78ca11b30e9fb73f5against based13c9f840d36a321a56917e75c48afcb8d72920e. Both the historical base and exact CI merge reproduce the same five failures (45 passing tests): four release preflight assertions and one same-named Mach-O slice fixture.This branch now merges upstream
bd2c202dd930548194cdbc55c27a797f22279db9, including release preflight fix747e7299141cec0b03774c427f579889d5088d20. Commit32e763a0765505ef567c565cff234c534e216ffefixes the remaining fixture: a neutral x86_64 slice allows target admission on x64 runners, while explicit--architecture arm64eretains both ARM subtype roots and all original evidence assertions. Production target admission is unchanged.Validated on the exact published tree
8d9f9def4878de0b9ccef889e5350febe5457216with Node 24.18.0 / npm 11.16.0: 50/50 focused release/dylib tests, 7/7 HTTP/3 lifecycle regressions, 120/120 CI scope/required-lane tests, and typecheck/lint. Pre-push checks passed. The earlier native HTTP/3 evidence remains pinned to891c7878dfd659437ba3c15799ef1d95abe3279c; no native traffic rerun is claimed for this CI integration. Fresh GitHub CI is pending.Producer TLS fact regression (2026-10-13)
Commit
0f7dc00273bc469a4aa2bea7320856b8a07095bfaddresses review comment 4257957176: positive records now preserve the UUID-matched producer's exacttls_version,timestamp_tls_setup, and connectionerroron both legs, alongside connection IDs. Producer version labels are compared as observations; timestamps are neither rounded nor given a tolerance.Twelve mutations that previously passed are now rejected. All 20 verifier regressions, static checks, strict lint, formatting, documentation checks, and pre-push checks pass on the published tree
e2f051f5bfbbbcac3cab18c7ec10fbfe9a8dfa44. The new assertions also pass on four retained CLI/MCP result views from the original real lab (runs41849ea4-7b4a-4fb3-93f4-d583d99ff812and80dc2ec6-2ae1-45c7-bfef-296ceedb5947), with all six input-file digests unchanged. This is historical evidence from source891c7878dfd659437ba3c15799ef1d95abe3279c; no new decoding or native traffic run is claimed for this commit. Fresh GitHub CI is pending.Readable capture-field regression (2026-10-13)
Commit
095dbb00428766cb50c4c3e429b23b74ceed5b6caddresses review comment 4258507827. In addition to retained bytes, positive assertions now compare readable method/scheme/authority/path against observed pseudo-fields, ordered request/response header pairs including duplicate values, and h3 ALPN on both legs. Expected text preserves the native decoder's strict UTF-8 semantics, including null display values for non-UTF-8 bytes.Fourteen readable-only mutations accepted before the fix are now rejected. All 34 verifier regressions pass; the guide runs both the lifecycle and newly separated assertion test files. Pinned Node 24.18.0 / npm 11.16.0 build, typecheck/lint, strict targeted lint, formatting, documentation and pre-push checks pass on tree
9626f7047c680e00d07234a308ca66ddaa65822e.The new assertions also pass over the four retained CLI/MCP result views of the earlier real lab, with all six input digests unchanged. Historical native evidence still belongs to
891c7878dfd659437ba3c15799ef1d95abe3279c; no decoding or native traffic rerun is claimed for this fix. Fresh GitHub CI is pending.