Repository navigation
fix(artifacts): preserve Mach-O load-command string identity - #2110
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@greptileai review |
|
Node timers can fire while performance.now() is still a fraction of a millisecond short of the monotonic deadline. ProviderStartupDeadline then reported interruption "timeout" and an aborted signal while remainingMs() returned ceil(0.x) = 1, so polling loops guarded by remainingMs() > 0 (Hopper and Ghidra startup) could run past an elapsed deadline, and the real-timer test "aborts a bounded wait when its real monotonic deadline expires" failed intermittently in CI (expected 1 to be 0). Once the deadline's own timer has classified a timeout, report zero remaining time. A deterministic regression test fires the timer with the monotonic clock 0.4 ms short of the deadline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit dfdaa0c)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c3c2f4e1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Source fixes and publication evidence for the review findings below. Tests and executable checks were skipped at the maintainer's request. Findings that still require a decision or execution evidence remain open. The branch carried an older deadline guard and regression alongside its Mach-O contribution. Captured main now owns a separately scoped monotonic deadline correction: early callbacks rearm the remaining budget and waits retain the absolute deadline. The merge removes the superseded guard/test from this branch's final change; ProviderDeadline.ts and ProviderDeadline.test.ts are identical to captured main. Contributor history is preserved, including the explicitly named process commit, while the final PR delta contains the artifact changes without an independent provider-deadline behavior change. Published at |
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2af17a3b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # scripts/lib/clean-linux-hopper-runtime.mjs
Summary
Preserve a leading U+FEFF when decoding NUL-terminated Mach-O load-command strings. It is part of the source name/path identity, not a text-file byte-order marker. Stripping it can change an install name and cause an unrelated dylib to appear to resolve.
Original Mach-O change author: @1052326311.
Scope
This PR changes only Mach-O string decoding and its parser/CLI regressions. It sets
ignoreBOM: trueon the existing fatal UTF-8 decoder; load-command bounds, NUL termination, and invalid UTF-8 rejection remain intact. The focused parser regression covers LC_ID_DYLIB, LC_LOAD_DYLIB, LC_RPATH, and LC_DYLD_ENVIRONMENT. The CLI regression checks ordinary and U+FEFF-prefixed names and confirms that the prefixed identity does not resolve as the ordinary library.The historical calls-only reconstruction policy change raised in review is not part of this PR's current diff. It is already on the current base in commit
688defca0 fix(comparison): recheck historical calls-only changes (#2223), authored by Lucien (164857476+dakjdakd@users.noreply.github.com).Validation
Maintenance review inspected the exact diff against current base, ran pinned Oxfmt 0.72.0 on the merge-conflict file, and ran
git diff --check. Tests and builds were not run in this maintenance pass. The captured earlier CI run was for the pre-merge head and reported a formatting issue inscripts/lib/clean-linux-hopper-runtime.mjsplus reconstruction comparison failures; the format issue was corrected during the current-base merge, and the comparison behavior is now on the base. Current-head CI is queued/in progress.