Repository navigation
fix(process): expose Darwin swiftc compile deadline via env - #2240
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@greptileai review |
|
This PR is set for a Plus review. TREX isn't supported with Plus or Apex reviews yet, so Greptile reviews this PR at Base while TREX is on. |
|
4b02075 to
b5d0f74
Compare
Busy hosts can exceed the hard-coded 60s ownership-helper compile timeout. Honor REA_SWIFTC_COMPILE_TIMEOUT_MS like the other provider startup deadlines, keeping 60000 as the default. Fixes morluto#2184 Co-authored-by: Cursor <cursoragent@cursor.com>
b5d0f74 to
c743ec2
Compare
|
Review findings addressed at their producing boundaries and consumers. Latest changes were reviewed from source; tests and provider runs were skipped at the maintainer's request. Findings requiring separate decisions or verification remain open. Handled in 5ade0c1. Removed swiftcCompileTimeoutMs from the parsed Config representation and its duplicate assertions. Environment admission still validates REA_SWIFTC_COMPILE_TIMEOUT_MS; DarwinProcessRunTokenReader remains the single runtime owner, with explicit options taking precedence over the environment and the existing default. Source inspection and git diff --check completed. Tests, builds, typechecking, lint, and real-provider verification were skipped at the user's explicit request. |
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com> (cherry picked from commit 688defc)
(cherry picked from commit 8cac51e)
(cherry picked from commit 1335bcd)
…2895) * fix: repair the static-check failures on the default branch The default branch fails its own required `Static checks` job three ways, so every pull request reports that job as failed regardless of its own change. - `npm run format:check` reports `src/domain/functionComparison.test.ts` and `src/ida/IdaOperationRunner.ts`. - `npm run lint` reports a duplicate `import { join } from "node:path"` in `tests/boundary/mcp/ghidraInventoryMcp.test.ts` (lines 4 and 17). - `npm run typecheck` reports `format: "devin"` missing from the client format union in `src/application/SupportedClients.ts`, and an unchecked index in `tests/boundary/cli/clientProfileLifecycle.test.ts`, whose pair array is inferred as `string[][]`. Apply the pinned formatter, drop the duplicate import, list the `"devin"` format that its own definition already uses, and mark the pair array `as const`. Validation: `npm run check:fast` and `npm run format:check` pass. * fix(setup): keep Devin on the JSON configuration dialect --------- Co-authored-by: 吴佳浩 <wujiahao@supremind.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com> (cherry picked from commit df3d96d)
Summary
REA_SWIFTC_COMPILE_TIMEOUT_MS(1–2147483647 ms, default 60000) for Darwin ownership-helperswiftccompilation.REA_GHIDRA_STARTUP_TIMEOUT_MS/REA_HOPPER_STARTUP_TIMEOUT_MS.Fixes #2184
Test plan
npm run test:focused -- src/config.test.ts src/process/DarwinProcessRunTokenReader.timeout.test.tsnpm run check:fastREA_SWIFTC_COMPILE_TIMEOUT_MS=loud rea analyze …→configuration_invalidnaming the settingREA_SWIFTC_COMPILE_TIMEOUT_MS=120000accepted byparseConfig