Skip to content

fix(process): expose Darwin swiftc compile deadline via env - #2240

Merged
morluto merged 8 commits into
morluto:mainfrom
BeqaKs:fix/swiftc-compile-timeout-env
Oct 13, 2026
Merged

morluto merged 8 commits into
morluto:mainfrom
BeqaKs:fix/swiftc-compile-timeout-env

Conversation

@BeqaKs

@BeqaKs BeqaKs commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add REA_SWIFTC_COMPILE_TIMEOUT_MS (1–2147483647 ms, default 60000) for Darwin ownership-helper swiftc compilation.
  • Wire it through config validation and the process-ownership host, matching REA_GHIDRA_STARTUP_TIMEOUT_MS / REA_HOPPER_STARTUP_TIMEOUT_MS.
  • Document the setting in installation and MCP contracts.

Fixes #2184

Test plan

  • npm run test:focused -- src/config.test.ts src/process/DarwinProcessRunTokenReader.timeout.test.ts
  • npm run check:fast
  • REA_SWIFTC_COMPILE_TIMEOUT_MS=loud rea analyze … → configuration_invalid naming the setting
  • REA_SWIFTC_COMPILE_TIMEOUT_MS=120000 accepted by parseConfig

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This PR is set for a Plus review. TREX isn't supported with Plus or Apex reviews yet, so Greptile reviews this PR at Base while TREX is on.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Adds REA_SWIFTC_COMPILE_TIMEOUT_MS for Darwin ownership-helper compilation.

  • Darwin helper compilation uses a deadline operators can configure.

Reviews (7) · Last reviewed commit: "chore: merge main into PR #2240" · Reviewed by Greptile

Comment thread src/config/parseConfig.ts Resolved
@BeqaKs
BeqaKs force-pushed the fix/swiftc-compile-timeout-env branch from 4b02075 to b5d0f74 Compare October 13, 2026 10:26
Busy hosts can exceed the hard-coded 60s ownership-helper compile
timeout. Honor REA_SWIFTC_COMPILE_TIMEOUT_MS like the other provider
startup deadlines, keeping 60000 as the default.

Fixes morluto#2184

Co-authored-by: Cursor <cursoragent@cursor.com>
@BeqaKs
BeqaKs force-pushed the fix/swiftc-compile-timeout-env branch from b5d0f74 to c743ec2 Compare October 13, 2026 11:34
@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Review findings addressed at their producing boundaries and consumers. Latest changes were reviewed from source; tests and provider runs were skipped at the maintainer's request. Findings requiring separate decisions or verification remain open.

  1. thread 1

Handled in 5ade0c1. Removed swiftcCompileTimeoutMs from the parsed Config representation and its duplicate assertions. Environment admission still validates REA_SWIFTC_COMPILE_TIMEOUT_MS; DarwinProcessRunTokenReader remains the single runtime owner, with explicit options taking precedence over the environment and the existing default.

Source inspection and git diff --check completed. Tests, builds, typechecking, lint, and real-provider verification were skipped at the user's explicit request.

@morluto morluto added bug Something isn't working performance Performance regressions, scaling limits, and bounded-resource work area: runtime Process capture and runtime observation area: setup Setup, packaging, upgrade, install, Doctor, and client registration area: providers Provider and capability discovery, including provider proposal triage P2: medium Medium priority issue labels Oct 13, 2026
skydavil and others added 6 commits October 13, 2026 23:02
* fix(comparison): preserve incomplete function call evidence

Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty.

Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls.

* fix(comparison): recheck historical calls-only changes

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
(cherry picked from commit 688defc)
…2895)

* fix: repair the static-check failures on the default branch

The default branch fails its own required `Static checks` job three ways, so
every pull request reports that job as failed regardless of its own change.

- `npm run format:check` reports `src/domain/functionComparison.test.ts` and
  `src/ida/IdaOperationRunner.ts`.
- `npm run lint` reports a duplicate `import { join } from "node:path"` in
  `tests/boundary/mcp/ghidraInventoryMcp.test.ts` (lines 4 and 17).
- `npm run typecheck` reports `format: "devin"` missing from the client format
  union in `src/application/SupportedClients.ts`, and an unchecked index in
  `tests/boundary/cli/clientProfileLifecycle.test.ts`, whose pair array is
  inferred as `string[][]`.

Apply the pinned formatter, drop the duplicate import, list the `"devin"` format
that its own definition already uses, and mark the pair array `as const`.

Validation: `npm run check:fast` and `npm run format:check` pass.

* fix(setup): keep Devin on the JSON configuration dialect

---------

Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
(cherry picked from commit df3d96d)
@morluto
morluto merged commit e4186af into morluto:main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: providers Provider and capability discovery, including provider proposal triage area: runtime Process capture and runtime observation area: setup Setup, packaging, upgrade, install, Doctor, and client registration bug Something isn't working P2: medium Medium priority issue performance Performance regressions, scaling limits, and bounded-resource work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: make the swiftc helper compile deadline (hard-coded 60 s) configurable

5 participants