Skip to content

docs(skill): route agent-driven browser actions to scenario capture - #2286

Merged
N0zoM1z0 merged 14 commits into
morluto:mainfrom
0xRafie:docs/skill-browser-action-routing
Oct 14, 2026
Merged

N0zoM1z0 merged 14 commits into
morluto:mainfrom
0xRafie:docs/skill-browser-action-routing

Conversation

@0xRafie

@0xRafie 0xRafie commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Choose browser tools by who performs the action: passive observation for user actions, declared capture_browser_scenario actions for agent tasks.

The skill explains connect/launch ownership, initial navigation and unsaved state, requested capture details, separate step outcomes, and request-initiator limits. Listener locations identify candidate handlers. It also lists focused follow-up tools and preserves passive-only reconciliation guidance.

Bump the bundled skill from 41 to 42 and regenerate package metadata. The diff contains two authored skill files and that derived version field.

Synced main through e049ef70 to include the repaired Ghidra profile fixtures and isolated CI report tests.

Validation

On Linux with pinned Node.js 24.18.0/npm 11.16.0:

  • docs:check: five conformance tests passed.
  • check:fast, full formatting and diff checks passed.
  • Focused suites on the synchronized revision: 61 tests passed (10 Ghidra profile, 8 CI report, 5 generated-skill, 38 response metadata).
  • Earlier verify:package on 738d02a: repository skill installation, package install/update, CLI/MCP workflows and cleanup passed. It was not rerun after this main sync.
  • Real Chromium 153 public CLI: default URL capture; selected DOM/accessibility/network capture with independently verified digests; connect mode preserving the external page and resetting unsaved form state through initial navigation. All declared steps completed and cleanup matched each mode.

An additional real inspect-web-page CLI probe retained gzip encoding, COOP policy and a Link query value while omitting credential/unselected header values.

Separate follow-up browser tools were checked against source contracts. Native Windows/macOS and agent transcripts were not rerun. Browser output sizes are observations, not token or performance benchmarks.

Contributor's earlier macOS evidence

The contributor reports checks on REA 6.4.0/main d96550f, macOS 26.7.1, Chrome 154 and Brave 155. Connect scenarios clicked #export, retained a 200 response and the expected final DOM, then disconnected. Listener inspection located export.js; the request initiator came from passive capture. Overlapping passive capture and scenario navigation returned target_unavailable / target_changed. Their connect capture remained incomplete due to pre-attach event coverage.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This PR is set for a Plus review. TREX isn't supported with Plus or Apex reviews yet, so Greptile reviews this PR at Base while TREX is on.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issue was found.

Summary

Routes agent-performed browser actions to capture_browser_scenario while keeping user-performed actions on passive tools.

  • The browser skill sends agent-performed actions through declared scenarios.
  • Passive captures now name the response details they keep.

Reviews (10) · Last reviewed commit: "chore(docs): synchronize repaired main t..." · Reviewed by Greptile

@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Review findings addressed at their producing boundaries and consumers. Latest changes were reviewed from source; tests and provider runs were skipped at the maintainer's request. Findings requiring separate decisions or verification remain open.

  1. thread 1

Fixed in a8ca747bf92cd60cba5141c7256b597ed5e372e0. The connect-mode guidance omitted the initial navigation performed by PlaywrightScenarioSession. The source skill now explicitly says connect mode first navigates to start_url, can clear unsaved values and temporary state, and requires recreating investigation state in the declared actions.

Validation: inspected the producing boundary and affected consumers; existing expectations were adjusted where the contract changed. Tests, mutation runs, builds, lint, typecheck and CI reruns were skipped at the user's explicit request. No new real-provider verification is claimed. This source correction does not settle separate integration authority or mutation-generation/score proof requirements.

@morluto morluto added documentation Improvements or additions to documentation area: setup Setup, packaging, upgrade, install, Doctor, and client registration P3: low Low priority, nice to have labels Oct 13, 2026
web-flow and others added 5 commits October 13, 2026 22:57
Integrate the verified main revision without rewriting the contributor's history.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Distinguish final capture artifacts from step outcomes, bound listener attribution,
and request only the evidence needed for the analyst question. Update the bundled
skill version and its generated package metadata together.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
N0zoM1z0 and others added 2 commits October 13, 2026 21:47
Integrate the verified main revision without rewriting the contributor's history.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Distinguish final capture artifacts from step outcomes, bound listener attribution,
and request only the evidence needed for the analyst question. Update the bundled
skill version and its generated package metadata together.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this route. Reviewed the final instructions against the current browser contracts and verified real launch/connect CLI scenarios, requested artifacts, initial navigation and cleanup on Linux Chromium. Documentation, typecheck/lint, formatting, generated-skill tests and package verification passed. The initiator and listener limitations are now explicit; the skill version and generated metadata agree.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the header wording issue in safeResponseMetadata and its boundary test: selected content encoding, policy values and Link URLs remain in passive evidence. I have stopped the merge watch and am correcting that paragraph with a real CLI metadata probe.

Distinguish discarded raw header collections from the selected response
projection, which preserves encoding, policy values and Link URLs.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header projection wording is corrected and matches both the production producer and a real public CLI capture. The passive metadata probe and 44 focused tests passed, as did updated documentation and package verification. Previously verified scenario routes, ownership, artifact selection and initiator limits remain unchanged.

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header projection wording is corrected and matches both the production producer and a real public CLI capture. The passive metadata probe and 44 focused tests passed, as did updated documentation and package verification. Previously verified scenario routes, ownership, artifact selection and initiator limits remain unchanged.

Integrate the verified main revision without rewriting the contributor's history.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the main synchronization. The PR still changes only the two authored skill files and their derived version metadata. The inherited npm cache-policy failure is fixed by main #3013; all 54 focused tests, documentation checks, typecheck/lint, formatting and full package verification passed on this head. Browser producer/contracts are unchanged from the real CLI probes.

@N0zoM1z0

N0zoM1z0 commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Both previous CI failures have been repaired on main. Synced those fixes in e7d8c29; 61 focused tests, docs, typecheck/lint, formatting and real Chrome launch/connect/passive CLI probes passed locally. Fresh CI is running on the synchronized revision.

Bring in the main fixes for the Ghidra profile fixture and isolated CI report tests.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

@N0zoM1z0 N0zoM1z0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the synchronized revision: the PR still changes only two skill documents and matching version metadata. Local docs, typecheck/lint, formatting, 61 focused tests and real Chrome launch/connect/passive CLI probes passed. Both previous CI failures were repaired on main and included in this revision.

@N0zoM1z0
N0zoM1z0 merged commit a6c3d3a into morluto:main Oct 14, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: setup Setup, packaging, upgrade, install, Doctor, and client registration documentation Improvements or additions to documentation P3: low Low priority, nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants