Repository navigation
feat(evm): add retained interface summary delivery - #2308
Merged
Merged
Conversation
Keep complete EVM output and provider inputs unchanged. Opt-in MCP summary retains original full Evidence and returns all inferred interface facts without hex or duplicate stdout; retained/portable reads preserve identity, uncertainty and original text. Reject unsupported retention before analysis. Verify exact SDK schemas, old defaults, portable sources, identity failures and peer views; record whole-question comparison and explicit old-server fallback. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Unwrap the named get_evidence_bundle result before locating original source records. Real SDK retained reads now verify full bytecode and original parameters without reanalysis; legacy complete calls and old-server summary fallback also pass. Preserve the initial failed harness receipt without attributing it to REA. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Record repeated real SDK/model comparisons including mixed token/time outcomes and strict limitation failures. Verify historical complete Evidence through public MCP and CLI with the producer limiter unavailable; preserve original records and input bytes. Keep generated receipts and artifacts outside Git. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Keep paired costs pinned to the original frozen runtimes. Record the clean latest-main rebase, 30 affected MCP tests, full static/docs gates and real retained/old-bundle SDK and CLI checks. Preserve the guarded static failure and lower-overhead successful retry without changing memory bounds. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
34 tasks done
3 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2016. Add opt-in EVM interface summary delivery while keeping existing complete CLI/MCP calls usable. Questions about inferred selectors and identities no longer need full hex and duplicate producer stdout inline; unchanged complete Evidence remains retained and accessible.
Repeated SDK replies are 43–87% smaller for three public inputs. Twelve real Codex trials show mixed token/time results, so this PR does not claim a stable model speedup or uniform token saving.
Problem and expected behavior
inspect_evm_interface({path, encoding})continues returning its complete Evidence. Selectingdetail: "summary"returns a distinct linkedinspect_analysis_viewsummary with all inferred candidates, offsets, arguments/mutability including null, identities, limitations and explicit unknowns. Bytecode hex and duplicate stdout remain accessible from the original parent. No interpreter work or provider selection is silently reduced.{"name":"inspect_evm_interface","arguments":{"path":"/artifacts/runtime.hex","encoding":"hex","detail":"summary"}}The returned
normalized_result.parent_evidence_idselects retainedfunctions,bytecode_hex,stdoutorstderrpages throughinspect_analysis_view. Summary coverage covers the returned candidate set; global discovery completeness remains unknown.Change and scope
Contract and boundary impact
detailand EVM view kind added. Actual converted input/output schemas are checked. Only the EVM and generic-view definitions change against the pinned control; old schemas accept new default replies.Expected effects:
Evidence and regression coverage
For evidence-bearing changes:
Validation performed
npm run test:focused -- tests/boundary/mcp/evmInterfaceMcp.test.ts tests/boundary/mcp/wasmArtifactMcp.test.ts tests/boundary/mcp/analysisViewMcp.test.ts src/application/analysisView/AnalysisViewService.test.ts src/domain/analysisView/analysisView.test.ts— 64 pass on the production feature.npm run checkandnpm run docs:check— pass before rebase; one guarded static-check attempt was stopped at the unchanged early-stop threshold and retained, then the bounded retry passed.0043d9b134c0a353e8bf85c0bde4492275f1f720, the three affected MCP suites pass (30 tests), full static/docs gates pass, and real current-runtime Factory retained/Pool old-bundle SDK and CLI workflows pass. The guarded integrated static-check attempt is preserved; running the same single Turbo typecheck with less launcher overhead passes, then the full gate passes using that valid cache. Memory thresholds and required checks remain unchanged.Compatibility, safety and release
/tmprecord.Detailed pins, sizes, all pair costs, failed attempts, grading qualifications and reproduction: EVM interface summary checkpoint.
Before merge
c575fb5390833d7d1b2957247bffc64755b43124; all 37 checks succeed. CI receipt. Bot review quota is exhausted, so automated approval is not claimed.