Repository navigation
fix(ida): preserve native coverage and verify returned values - #2324
Conversation
Reject native callee successes without an explicit truncation marker while preserving producer error reasons. Require positive procedure inventory/search results and compare normalized function results with the CLI/MCP dossier. Add caller-selected string and xref oracles; explicitly report those behaviors as unverified when no independent oracle is supplied. Verified with Windows IDA Pro 9.3 and the native MCP plugin on the unchanged public fixture. Eight production checks passed with a literal independently confirmed in fixture bytes and an xref source address identified from main assembly matching the C source. A response-only loopback proxy reproduced the earlier verifier passing empty inventories/xrefs; the corrected verifier rejected those results, empty strings and omitted callee markers. This used IDA Pro, not Windows IDA Free. No personal paths or license registration information are included. Validation: 207 focused tests, serial static checks, architecture guards, discovery and docs checks passed. Public-entry regressions use an explicitly simulated native provider and owned process supervision; they do not establish real-engine behavior. Follow-up to #1544.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Checked this branch merged into |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The shared ELF parser validates the complete header extent. Three ELF64 installation fixtures still declared a 52-byte file despite containing 64-byte headers, turning positive format evidence into unknown evidence. Construct complete-file probes from their bytes in one place, preserving incompatible, truncated and unreadable-header assertions. Reproduced all three CI failures before the correction. All 115 related Ghidra installation/doctor and ELF target/header tests pass afterward. The IDA changes in this PR were verified with Windows IDA Pro 9.3, not IDA Free; this fixture-only correction adds no real-Ghidra verification.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Follow up the two late review findings on #1544: reject unknown native callee truncation and verify returned values in the real-provider lane.
moremarker; missing markers remain protocol failures. Upstream failures retain their original reason and observations.--expected-stringand--expected-xrefpositive oracles. Without independent oracles, report string/xref correctness asunverified. Callee parity does not establish semantic completeness.Scope and contracts
Fixes within the existing attached native IDA profile and verification harness, plus the diagnosed CI fixture correction; a new-provider or mutation scope decision is not applicable. Existing CLI/MCP tool schemas, caller choices and legacy/modern behavior are preserved. The parser owns native coverage interpretation. No database save/close, target execution, installation, GUI startup or new analysis cache is introduced. Validation adds constant work to a native callee page; verification reuses the responses already requested.
Validation
c9d15d98e8a143fc74f6e14037c48f63889b6d6c, including its navigation correction and a local loopback listener: eight production CLI/MCP checks passed on the unchanged public fixture. The expected CRT literal was confirmed independently in fixture bytes; the expected reference source address was identified frommainassembly matching the C source.d1aaeee40with the same current adapter runtime; it is not an engine-performance comparison.See the verification and historical performance note. Its before/after measurements retain their historical source pins; this parser/verification correction adds no performance improvement claim.
Review findings addressed
CI and review must complete on this PR's current head before merge.
CI baseline diagnosis
The initial run on
85c36abe3failedreferenceSourceImportStatus.test.tsin test shard 2 and the Windows lane. Independent main CI onf611d8ce7fails the exact same cases: two Linux full-output preflight cases and those two plus the Windows readable-root case. Main commit570c40cdechanged full-output failures took: false/error, while those assertions still expectok: true/data. This PR does not touch that CLI output implementation or those tests. This is a confirmed main baseline failure; unrelated code is kept out of this fix.The refreshed run on
d8baca68fencountered three Ghidra decompiler-header fixture failures insrc/ghidra/GhidraInstallation.test.ts. Independent main CI on the exact integrated basec462a4ebdhas the same three failures in both Windows and shard 4. The Ghidra test, implementation, and ELF-header producer are identical to main. The initial diagnosis kept unrelated code out. Following the maintainer request to fix CI, commitd1e0b1095repairs only the inconsistent fixture metadata: ELF64 bytes are 64 bytes, while the old probes declared a 52-byte file. A shared test helper derives size from the actual buffer for complete-file probes; the expected compatible/incompatible/unknown outcomes remain unchanged. All three failures reproduced locally before the correction, and all 115 relevant Ghidra installation/doctor and ELF-header/target tests pass afterward. This does not add real-Ghidra provider verification.Current integration status
Manual Codex review completed on
85c36abe3without findings. Its initial CI failures were independently reproduced on main, as documented above. Main subsequently fixed the stale assertions in8224aeba9. This branch now incorporates mainc462a4ebdthrough merged8baca68f; no separate unrelated CLI edits were added to this PR. On integrated headd8baca68f, all 207 focused tests and serial typecheck/lint/format/knip/metadata checks passed, including the pre-push gate. Automated Codex review completed ond8baca68fwithout findings. That run completed with 32 successful jobs; only the Ghidra cases failed in Windows and shard 5, causing the two aggregate failures. Commitd1e0b1095fixes those fixtures; 115 related tests, serial typecheck/lint/format and commit hooks pass. On corrected headd1e0b1095, automated review completed without findings or unresolved threads. CI run 38327862093 completed successfully: all 36 jobs passed, including all six test shards, coverage/timing, the Windows capability/package lane, real Apple CLI/MCP workflows, andCI required.Merged as
37b7550ecc916acc8619fa72e5c05af45702733fafter exact-head review and all 36 CI jobs passed. The two late #1544 review threads have been explained and resolved.Test cleanup removed the portable Windows runtime, Node and transient reports and probes. Attached test GUI inputs/databases and compact real-provider receipts are retained; no GUI database was saved or closed.