Repository navigation
test(ghidra): declare the Java minimum in boundary installation fixtures - #2633
kaoru0822-kitauji wants to merge 1 commit into
Conversation
2187e16 made Ghidra installation admission require `application.java.min` from application.properties and updated the unit fixtures, but four boundary fixtures still declared only `application.version`. Their providers now resolve as unavailable, so 43 tests in 11 boundary files (Ghidra MCP harness users, reopen, PSP extension, Java launch) fail on main. Two updated unit tests also fail format:check, which blocks Static checks on every PR. Declare `application.java.min=21` in the remaining fixtures and apply oxfmt to the two unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Also checked: |
|
Superseded by 18d56f5 on main, which makes the same change to the same six files (application.java.min=21 in the four boundary fixtures plus oxfmt on the two unit tests). Closing. |
|
Thanks @kaoru0822-kitauji for aligning the Ghidra test fixtures with the supported Java boundary. Those fixture corrections are on main. |
Problem
Main CI has been red since 2187e16 (
fix(ghidra): derive installation admission from Java property semantics). Every PR's merge build shows the same failures:Static checks:
format:checkreportssrc/ghidra/GhidraDoctor.test.tsandsrc/ghidra/GhidraSnapshotCache.test.ts. Both are reformatted lines from that commit.Test shards: 2187e16 made admission require
application.java.minfromapplication.properties. It updated the unit-test fixtures, but these boundary fixtures still declare onlyapplication.version:tests/boundary/mcp/ghidraMcpHarness.ts, used by 9 MCP suitestests/boundary/mcp/ghidraReopen.test.tstests/boundary/filesystem/ghidraPspExtension.test.tstests/boundary/providers/ghidra/ghidraJavaLaunch.test.tsTheir providers now resolve as unavailable (
Provider ghidra adapter failed during resolve_analysis_profile). That fails 43 tests in 11 boundary files, for exampleghidraJavaLaunch.test.ts > Ghidra startup interruption diagnostics > preserves helper warnings through the provider-neutral cancelled projection.Fix
application.java.min=21to the four remaining fixtures, matching the unit fixtures in 2187e16.oxfmton the two unit tests.Only test files change.
Validation
npm run test:focusedover the 11 affected boundary files plus the two unit tests (13 files):origin/main(9188698)npm run format:checkis clean.🤖 Generated with Claude Code
Summary by CodeRabbit