Skip to content

test(ghidra): declare the Java minimum in boundary installation fixtures - #2633

Closed
kaoru0822-kitauji wants to merge 1 commit into
mainfrom
test/ghidra-java-min-fixtures
Closed

kaoru0822-kitauji wants to merge 1 commit into
mainfrom
test/ghidra-java-min-fixtures

Conversation

@kaoru0822-kitauji

@kaoru0822-kitauji kaoru0822-kitauji commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Main CI has been red since 2187e16 (fix(ghidra): derive installation admission from Java property semantics). Every PR's merge build shows the same failures:

  • Static checks: format:check reports src/ghidra/GhidraDoctor.test.ts and src/ghidra/GhidraSnapshotCache.test.ts. Both are reformatted lines from that commit.

  • Test shards: 2187e16 made admission require application.java.min from application.properties. It updated the unit-test fixtures, but these boundary fixtures still declare only application.version:

    • tests/boundary/mcp/ghidraMcpHarness.ts, used by 9 MCP suites
    • tests/boundary/mcp/ghidraReopen.test.ts
    • tests/boundary/filesystem/ghidraPspExtension.test.ts
    • tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts

    Their providers now resolve as unavailable (Provider ghidra adapter failed during resolve_analysis_profile). That fails 43 tests in 11 boundary files, for example ghidraJavaLaunch.test.ts > Ghidra startup interruption diagnostics > preserves helper warnings through the provider-neutral cancelled projection.

Fix

  • Add application.java.min=21 to the four remaining fixtures, matching the unit fixtures in 2187e16.
  • Run oxfmt on the two unit tests.

Only test files change.

Validation

npm run test:focused over the 11 affected boundary files plus the two unit tests (13 files):

result
origin/main (9188698) 43 failed, 54 passed
this branch 97 passed

npm run format:check is clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated Ghidra test fixtures to specify Java 21 as the minimum supported version, consistent with their Java version probes.

2187e16 made Ghidra installation admission require
`application.java.min` from application.properties and updated the unit
fixtures, but four boundary fixtures still declared only
`application.version`. Their providers now resolve as unavailable, so 43
tests in 11 boundary files (Ghidra MCP harness users, reopen, PSP
extension, Java launch) fail on main. Two updated unit tests also fail
format:check, which blocks Static checks on every PR.

Declare `application.java.min=21` in the remaining fixtures and apply
oxfmt to the two unit tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T06:07:46.786296Z 4964383 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9e9bab0-39a8-41e8-ad4e-828fb0d251df
📥 Commits

Reviewing files that changed from the base of the PR and between 9188698 and 4964383.

📒 Files selected for processing (6)
  • src/ghidra/GhidraDoctor.test.ts
  • src/ghidra/GhidraSnapshotCache.test.ts
  • tests/boundary/filesystem/ghidraPspExtension.test.ts
  • tests/boundary/mcp/ghidraMcpHarness.ts
  • tests/boundary/mcp/ghidraReopen.test.ts
  • tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Several Ghidra test fixtures now declare Java 21 as the minimum version. Two test callbacks have formatting-only changes.

Changes: Ghidra test fixture updates

Layer / File(s) Summary
Align Java version fixtures
tests/boundary/filesystem/ghidraPspExtension.test.ts, tests/boundary/mcp/ghidraMcpHarness.ts, tests/boundary/mcp/ghidraReopen.test.ts, tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts, src/ghidra/GhidraDoctor.test.ts, src/ghidra/GhidraSnapshotCache.test.ts
Four boundary test fixtures now declare Java 21 as the minimum version. Two unit test callbacks are reformatted without changing their fixture data.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: morluto

Merge Risk: ⚪ Minimal · up to 49643

The test fixtures now satisfy the Java-version admission requirement, and the remaining changes preserve their existing data. No merge-blocking risk remains.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The description explains the problem, fix, affected fixtures, and validation results, but it does not follow the required template. It omits the required contract and boundary impact, scope, compatibi… Update the description to use the repository template. Add the required sections and complete applicable fields, including scope fit, contract and boundary impact, evidence and regression coverage, validation commands, compatibility and saf…
Passed Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: adding the Java minimum to Ghidra boundary installation fixtures.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, fix, affected fixtures, and validation results, but it does not follow the required template. It omits the required contract and boundary impact, scope, compatibility and safety, evidence coverage, remaining proof gaps, and before-merge sections.

Resolution

Update the description to use the repository template. Add the required sections and complete applicable fields, including scope fit, contract and boundary impact, evidence and regression coverage, validation commands, compatibility and safety, release impact, and the before-merge checklist. Mark non-applicable items explicitly.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kaoru0822-kitauji

Copy link
Copy Markdown
Collaborator Author

Also checked: analysisViewMcp.test.ts and inlineEvidenceCompositionMcp.test.ts fail in the same shards on current PR runs (they use the Ghidra MCP harness). With this branch both pass (15 tests).

@kaoru0822-kitauji

Copy link
Copy Markdown
Collaborator Author

Superseded by 18d56f5 on main, which makes the same change to the same six files (application.java.min=21 in the four boundary fixtures plus oxfmt on the two unit tests). Closing.

@kaoru0822-kitauji
kaoru0822-kitauji deleted the test/ghidra-java-min-fixtures branch October 13, 2026 06:23
@morluto morluto added area: tests Test suite and verification area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Thanks @kaoru0822-kitauji for aligning the Ghidra test fixtures with the supported Java boundary. Those fixture corrections are on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior area: tests Test suite and verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants