Repository navigation
feat(setup): add Kimi Code client support - #2744
Merged
Merged
Conversation
Registers rea in ~/.kimi-code/mcp.json (or $KIMI_CODE_HOME/mcp.json), preserving unrelated settings with a .rea.backup; registration is command-based stdio with no type field, startupTimeoutMs 30000 and toolTimeoutMs 120000 from MCP_STARTUP_POLICY. Strict JSON parsing: empty or whitespace-only files initialize; malformed JSON is rejected untouched with no backup; explicit transport other than stdio reports invalid. Bundled skill uses the shared ~/.agents/skills destination that Kimi Code discovers, installed and verified through the shared-skill flow. Validated by 19 Kimi-specific tests, 260 adjacent-client regressions passing, check:fast and docs:check, and real-client verification on Kimi Code 0.40.1 (173 tools discovered, real mcp__rea__analyze_javascript_application call succeeded).
ysntony
marked this pull request as ready for review
October 13, 2026 10:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
3 tasks done
9 of 16 tasks
10 tasks done
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Kimi Code (
kimi) as a supported client forrea setup/rea doctor.Behavior changes
rea setup --client kimiregisters REA's MCP server in~/.kimi-code/mcp.json(or$KIMI_CODE_HOME/mcp.jsonwhen set), preserving unrelated settings and writing a.rea.backupbefore modifying an existing file.The registration is command-based with no
typefield: Kimi Code treats acommandentry as stdio.startupTimeoutMs = 30000(Kimi's default) andtoolTimeoutMs = 120000are set from the sharedMCP_STARTUP_POLICY.Package-launcher registration reuses the shared pinned-version rule and Windows wrapping.
Config parsing is strict JSON: an empty or whitespace-only file is initialized; malformed JSON is rejected with the file left untouched and no backup created.
An explicit
transport: "stdio"is treated as aligned (normalized away on write); any other explicit transport is reported as invalid.Repeat setup is idempotent: a second run reports
unchangedwith the file byte-identical.Skills
Kimi Code discovers personal skills in
~/.agents/skillsand project-local.agents/skills, so the bundled skill uses the shared skill destination with no separate skill root; the files are still installed and verified through the shared-skill flow.Validation
$KIMI_CODE_HOMEoverride, registration lifecycle (register, preserve, backup, idempotent, uninstall), launchers on Linux and Windows, transport and timeout validation, and foreign-command detection.check:fastanddocs:checkpass;git diff --checkis clean.enabledToolsavoids this.