Repository navigation
fix(uninstall): remove the REA-owned ZCode fallback registration #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a3320f2
fix(uninstall): remove the REA-owned ZCode fallback registration
kaoru0822-kitauji 6ae4887
fix(uninstall): preserve the strict ZCode fallback dialect
morluto 00a334a
chore: merge captured main into PR 2783
morluto 235d611
fix(comparison): recheck historical calls-only changes (#2223)
dakjdakd cf95368
fix(ci): isolate Linux Hopper process fixture inventory
morluto ffd9866
fix(android): make DEX descriptor pattern portable
morluto 014e5bf
fix: repair the static-check failures on the default branch (#2895)
XiaoBinGan b2578ba
chore(merge): refresh PR #2783 with main
morluto 7c716b4
chore(merge): refresh PR #2783 with latest main
morluto 47422fd
Merge branch 'main' into fix/issue-2664
morluto 6305f83
Merge remote-tracking branch 'origin/main' into fix/issue-2664
kaoru0822-kitauji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the fallback copy or write fails after preflight (for example, a filesystem error while creating its backup),
removeAllstops without rolling back the already-removed native entry. With this ordering, a native table whose only server was REA becomes empty while the fallback still contains REA, so ZCode activates the fallback registration again despite uninstall reporting failure. Process the fallback entry before the native entry so a later native failure leaves the active native registration intact.Useful? React with 👍 / 👎.