Repository navigation
feat(artifacts): inspect classic iNES container regions - #2816
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc8a3e6078
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* fix: repair the static-check failures on the default branch
The default branch fails its own required `Static checks` job three ways, so
every pull request reports that job as failed regardless of its own change.
- `npm run format:check` reports `src/domain/functionComparison.test.ts` and
`src/ida/IdaOperationRunner.ts`.
- `npm run lint` reports a duplicate `import { join } from "node:path"` in
`tests/boundary/mcp/ghidraInventoryMcp.test.ts` (lines 4 and 17).
- `npm run typecheck` reports `format: "devin"` missing from the client format
union in `src/application/SupportedClients.ts`, and an unchecked index in
`tests/boundary/cli/clientProfileLifecycle.test.ts`, whose pair array is
inferred as `string[][]`.
Apply the pinned formatter, drop the duplicate import, list the `"devin"` format
that its own definition already uses, and mark the pair array `as const`.
Validation: `npm run check:fast` and `npm run format:check` pass.
* fix(setup): keep Devin on the JSON configuration dialect
---------
Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
(cherry picked from commit df3d96d)
|
Source fixes and publication evidence for the review findings below. Tests and executable checks were skipped at the maintainer's request. Findings that still require a decision or execution evidence remain open. Status: Source fix pushed; public head verified with gh pr view. Validation is source-only; no tests/builds/checks/CI reruns were run. Root cause, owner-level fix, and any residual cleanup are recorded in the per-PR result. This is not a claim of exact CI reproduction. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 346275525e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Conflict sweep: I did not merge |
# Conflicts: # src/artifacts/createArtifactReader.ts # src/artifacts/extraction/ArtifactExtraction.ts # src/artifacts/inventory/ArtifactGraphConstruction.ts # src/artifacts/inventory/classify.ts # src/artifacts/inventory/reader.ts # src/contracts/artifactToolContracts.ts # src/domain/artifactFormatMetadata.ts
# Conflicts: # src/artifacts/extraction/ArtifactExtraction.ts # src/artifacts/inventory/classify.ts
…sh) into embedded-integration
…s branch already resolved morluto#2816 with every topic, so the tree is unchanged
Continues #2087, originally contributed by @Zhong-fan (记得吃中饭; Git author 64579525). The contributor fork rejected a normal maintainer push with permission denied, so this replacement preserves the contribution on a writable branch. Credit for the iNES implementation and subsequent fixes remains with @Zhong-fan; authorship and merge history are retained without squashing.
The closed original PR's current head
480a467dac220c36f621a5bc6f2fa3f65c4fda84is an ancestor of replacement headee4a11df812d63dc9c946dcb43b890c60f4d4e8b. Git ancestry and the canonicalrefs/pull/2087/headwere verified after the push. All 41 original commits outside captured main history are retained. The earlier replacement merge2904bdb4f8b0c4c7c4ebfa1737220b0fb84cb2ccpreserves prior original head00f31692b53ea382af159c0cbaf7635aa69c5450and exact captured mainc6503edfc4afdc0de6812ba3f7cd0909df5555f7as its two parents. The attribution syncee4a11df812d63dc9c946dcb43b890c60f4d4e8bthen merges the contributor's480a467dac220c36f621a5bc6f2fa3f65c4fda84into that replacement. The contributor commit was made at 2026-10-13 13:46:10 UTC, before original closure at 13:53:18 UTC; its older main parent was already in the captured target. No later main was fetched or chased.The inherited contribution inspects classic iNES headers and regions, preserving source bytes and reconstruction provenance without inferring executable architecture from a container signature. The shared Evidence schema retains
ineswith unknown container architecture (null);6502remains valid only for explicit raw-binary selections. The contributor's matching schema resolution and additional iNES/null-architecture and 6502-rejection assertions are preserved, along with the Ghidra Windows runtime-isolation test grouping and all earlier source fixes.The captured-main resolution previously received source inspection, targeted formatting with two threads, and
git diff --check. This attribution sync received source/diff inspection and Git ancestry/ref verification only. Tests, builds, lint, typechecks, provider workloads, benchmarks and CI reruns were skipped at the user's explicit request. No fresh runtime/provider verification or performance measurements are claimed. No GitHub metadata/review/comment writes were made during this sync.Author readiness
Human owner: @morluto