Skip to content

feat(artifacts): inspect classic iNES container regions - #2816

Merged
morluto merged 55 commits into
mainfrom
fix/main-sync-2087-captured-c6503ed
Oct 31, 2026
Merged

morluto merged 55 commits into
mainfrom
fix/main-sync-2087-captured-c6503ed

Conversation

@morluto

@morluto morluto commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Continues #2087, originally contributed by @Zhong-fan (记得吃中饭; Git author 64579525). The contributor fork rejected a normal maintainer push with permission denied, so this replacement preserves the contribution on a writable branch. Credit for the iNES implementation and subsequent fixes remains with @Zhong-fan; authorship and merge history are retained without squashing.

The closed original PR's current head 480a467dac220c36f621a5bc6f2fa3f65c4fda84 is an ancestor of replacement head ee4a11df812d63dc9c946dcb43b890c60f4d4e8b. Git ancestry and the canonical refs/pull/2087/head were verified after the push. All 41 original commits outside captured main history are retained. The earlier replacement merge 2904bdb4f8b0c4c7c4ebfa1737220b0fb84cb2cc preserves prior original head 00f31692b53ea382af159c0cbaf7635aa69c5450 and exact captured main c6503edfc4afdc0de6812ba3f7cd0909df5555f7 as its two parents. The attribution sync ee4a11df812d63dc9c946dcb43b890c60f4d4e8b then merges the contributor's 480a467dac220c36f621a5bc6f2fa3f65c4fda84 into that replacement. The contributor commit was made at 2026-10-13 13:46:10 UTC, before original closure at 13:53:18 UTC; its older main parent was already in the captured target. No later main was fetched or chased.

The inherited contribution inspects classic iNES headers and regions, preserving source bytes and reconstruction provenance without inferring executable architecture from a container signature. The shared Evidence schema retains ines with unknown container architecture (null); 6502 remains valid only for explicit raw-binary selections. The contributor's matching schema resolution and additional iNES/null-architecture and 6502-rejection assertions are preserved, along with the Ghidra Windows runtime-isolation test grouping and all earlier source fixes.

The captured-main resolution previously received source inspection, targeted formatting with two threads, and git diff --check. This attribution sync received source/diff inspection and Git ancestry/ref verification only. Tests, builds, lint, typechecks, provider workloads, benchmarks and CI reruns were skipped at the user's explicit request. No fresh runtime/provider verification or performance measurements are claimed. No GitHub metadata/review/comment writes were made during this sync.

Author readiness

Human owner: @morluto

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc8a3e6078

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/artifacts/ArtifactProvider.ts Resolved
Comment thread src/artifacts/inventory/reader.ts Resolved
Comment thread tests/acceptance/inesContainer.test.ts Resolved
Comment thread src/artifacts/ArtifactProvider.ts Resolved
* fix: repair the static-check failures on the default branch

The default branch fails its own required `Static checks` job three ways, so
every pull request reports that job as failed regardless of its own change.

- `npm run format:check` reports `src/domain/functionComparison.test.ts` and
  `src/ida/IdaOperationRunner.ts`.
- `npm run lint` reports a duplicate `import { join } from "node:path"` in
  `tests/boundary/mcp/ghidraInventoryMcp.test.ts` (lines 4 and 17).
- `npm run typecheck` reports `format: "devin"` missing from the client format
  union in `src/application/SupportedClients.ts`, and an unchecked index in
  `tests/boundary/cli/clientProfileLifecycle.test.ts`, whose pair array is
  inferred as `string[][]`.

Apply the pinned formatter, drop the duplicate import, list the `"devin"` format
that its own definition already uses, and mark the pair array `as const`.

Validation: `npm run check:fast` and `npm run format:check` pass.

* fix(setup): keep Devin on the JSON configuration dialect

---------

Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
(cherry picked from commit df3d96d)
@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

Source fixes and publication evidence for the review findings below. Tests and executable checks were skipped at the maintainer's request. Findings that still require a decision or execution evidence remain open.

review thread

Status: Source fix pushed; public head verified with gh pr view. Validation is source-only; no tests/builds/checks/CI reruns were run. Root cause, owner-level fix, and any residual cleanup are recorded in the per-PR result. This is not a claim of exact CI reproduction.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 346275525e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/artifacts/ArtifactProvider.ts Resolved
Comment thread src/application/BinaryTargetResolver.ts Resolved
Comment thread src/artifacts/ArtifactProvider.ts Resolved
@kaoru0822-kitauji

Copy link
Copy Markdown
Collaborator

Conflict sweep: I did not merge main into this branch, and it is unchanged. Merging main conflicts in 16 files, about 30 hunks. The artifact files (classify.ts, inventory reader.ts/scanCanonical.ts/scanReader.ts, artifactGraph.ts, ArtifactHash.ts, BinaryTargetResolver.ts) look mechanically combinable with the iNES additions. The Playwright files are a design conflict, though. This branch's PLAYWRIGHT_SCENARIO_CLEANUP_TIMEOUT_MS and its draining cleanup.close(() => events.finish()) meet main's redesigned cleanup: CLEANUP_CONFIRMATION_TIMEOUT_MS, service-worker shutdown, and per-limit network body allocation. Choosing between those needs a maintainer decision on browser cleanup semantics, so I left the branch for a maintainer rather than push a guessed resolution.

# Conflicts:
#	src/artifacts/createArtifactReader.ts
#	src/artifacts/extraction/ArtifactExtraction.ts
#	src/artifacts/inventory/ArtifactGraphConstruction.ts
#	src/artifacts/inventory/classify.ts
#	src/artifacts/inventory/reader.ts
#	src/contracts/artifactToolContracts.ts
#	src/domain/artifactFormatMetadata.ts
# Conflicts:
#	src/artifacts/extraction/ArtifactExtraction.ts
#	src/artifacts/inventory/classify.ts
@morluto
morluto merged commit 22e5aa9 into main Oct 31, 2026
52 checks passed
@morluto
morluto deleted the fix/main-sync-2087-captured-c6503ed branch October 31, 2026 07:49
Entrpi added a commit to Entrpi/rea that referenced this pull request Oct 31, 2026
Entrpi added a commit to Entrpi/rea that referenced this pull request Oct 31, 2026
…s branch already resolved morluto#2816 with every topic, so the tree is unchanged
@morluto morluto mentioned this pull request Nov 11, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: domain Domain logic, errors, and pure functions area: evidence Evidence, artifacts, and reconstruction area: server Server layer and tool wiring enhancement New feature or request P2: medium Medium priority issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants