Skip to content

fix(docs): update browser capture guide link after move - #2820

Merged
morluto merged 1 commit into
morluto:codex/review-fixes-pr-2403from
UndefinedDump:fix/docs-browser-capture-link
Oct 13, 2026
Merged

morluto merged 1 commit into
morluto:codex/review-fixes-pr-2403from
UndefinedDump:fix/docs-browser-capture-link

Conversation

@matbrgz

@matbrgz matbrgz commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

The documentation move in #2791 leaves the browser guide pointing to the removed docs/web-network-captures.md. check_repository_links reports a missing repository target, which blocks the website checks and the manual publishing gate.

Update the authored href to docs/guides/web/web-network-captures.md and regenerate its protected-link comments in the gettext template and 18 translation catalogs. All 30,780 translation entries retain their messages, translations, flags and metadata.

This follow-up targets codex/review-fixes-pr-2403 so it can be incorporated into #2791. It addresses the P1 “Moved guide breaks website checks” review finding.

Validation:

  • Reproduced the missing-target error on docs: organize canonical documentation layout and verify new pages #2791 head ce3a418715e90b666eae8be193948c7bd3cba710; repository-link validation passes after the fix.
  • Full scripts/website.py check with Python 3.13 and TMPDIR=/private/tmp: 344 HTML pages, 22,009 local references, 342 indexable pages in 19 languages, and all 12 maintenance regressions passed. Tests ran outside the sandbox to permit their local HTTP servers.
  • HTML formatting and git diff --check passed.

Refresh gettext protected-link comments alongside the authored href.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T13:58:19.616888Z 351ec94 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5 Tier: plus

[Low impact] This PR appears safe to merge; the corrected link points to the moved guide and translations remain unchanged.

Summary

Fixes the browser guide’s link to docs/guides/web/web-network-captures.md after the document moved.

  • The browser guide links to the moved network capture guide.

Reviews (1) · Last reviewed commit: "fix(docs): update browser capture guide ..." · Reviewed by Greptile

@morluto morluto added bug Something isn't working documentation Improvements or additions to documentation i18n Translations and localization workflow P3: low Low priority, nice to have labels Oct 13, 2026
@morluto
morluto merged commit 25e0709 into morluto:codex/review-fixes-pr-2403 Oct 13, 2026
1 check passed
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Welcome to REA, @matbrgz! Thanks for repairing the browser guide's link after the documentation move and updating the translation-catalog references. Readers can reach the capture guide again.

morluto added a commit that referenced this pull request Nov 7, 2026
…2791)

* docs: organize canonical documentation layout (URGENTE)

Group all existing authored guides by domain and ownership, expose complete navigation, and preserve their public routes. Update physical path consumers and release configuration while retaining historical records. Document domain-based specs and ADR slugs without global numbering.

Co-Authored-By: Codex <noreply@openai.com>

* fix(docs): honor home layout in all-page route verification

* style: format reviewed source changes

* fix(docs): preserve routes and navigation cache inputs

* fix: repair the static-check failures on the default branch (#2895)

* fix: repair the static-check failures on the default branch

The default branch fails its own required `Static checks` job three ways, so
every pull request reports that job as failed regardless of its own change.

- `npm run format:check` reports `src/domain/functionComparison.test.ts` and
  `src/ida/IdaOperationRunner.ts`.
- `npm run lint` reports a duplicate `import { join } from "node:path"` in
  `tests/boundary/mcp/ghidraInventoryMcp.test.ts` (lines 4 and 17).
- `npm run typecheck` reports `format: "devin"` missing from the client format
  union in `src/application/SupportedClients.ts`, and an unchecked index in
  `tests/boundary/cli/clientProfileLifecycle.test.ts`, whose pair array is
  inferred as `string[][]`.

Apply the pinned formatter, drop the duplicate import, list the `"devin"` format
that its own definition already uses, and mark the pair array `as const`.

Validation: `npm run check:fast` and `npm run format:check` pass.

* fix(setup): keep Devin on the JSON configuration dialect

---------

Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>

* fix(docs): update links after guide relocation

* docs: correct verified documentation route counts

* fix(docs): update browser capture guide link after move (#2820)

Refresh gettext protected-link comments alongside the authored href.

Co-authored-by: Codex <noreply@openai.com>

* fix(docs): include http3 lab in stable routes

* fix(docs): preserve historical release evidence and links

* fix(ghidra): restore Windows verifier identity import

* docs(wakaru): preserve pinned upstream policy link

* docs(index): retain recently added guide links

* docs(mcp): preserve parent retention clarification

* fix(cli): preserve standalone import guidance

* fix(test): preserve translated guide link drift coverage

---------

Co-authored-by: Matheus Breguêz <matbrgz@gmail.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: morluto <17176810+morluto@users.noreply.github.com>
Co-authored-by: 吴佳浩Alben <35291372+XiaoBinGan@users.noreply.github.com>
Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation i18n Translations and localization workflow P3: low Low priority, nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants