Repository navigation
fix(qlog): list a hidden stream's records without spreading call arguments - #2860
Conversation
…ments When an explicit declaration matched a stream's derived total, the decoder pushed every contribution ordinal with a spread call. A stream with more than ~125k STREAM frames exceeded the engine's argument limit, so a valid capture within the input budget failed with RangeError instead of listing the records as incomplete. Push the ordinals in a loop.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
|
Thanks for #2860, @Dragolone. Replacing the large spread with an iterative push keeps a valid qlog capture from crashing when a hidden stream has many contributing records, and the regression pins the full set of incomplete record ordinals. Great catch on this scale edge case. |
Summary
When an explicit sensitive value matches a qlog stream's derived total, the decoder omits the stream and lists its contributing records as incomplete. It did this with
incomplete_fact_records.push(...stream.contributions.map(...)). A stream with more contributions than the engine's call-argument limit (about 125k on Node 24) makes that spread throwRangeError: Maximum call stack size exceeded. A valid capture within the input budget then fails instead of being reported with incomplete records.This is the same class as #1538/#1539. No issue is linked: I searched issues and PRs for "qlog", "Maximum call stack" and "RangeError" and found no qlog report.
Problem and expected behavior
Smallest trigger: 130,000 one-byte STREAM frames on stream 0, packed 1,000 per
transport:packet_sentevent (130 events), decoded with the sensitive value"130000", which matches the stream's derivedunique_bytes/frame_length_sum.RangeError: Maximum call stack size exceeded. In the CLI/MCP path, the decoder process reports this as an unexpected decoder failure.streams: []andincomplete_fact_records= ordinals 0–129.Reaching this needs several STREAM frames per event. aioquic usually logs one frame per packet, and in that layout the decoder heap limit is reached first, which is the documented resource constraint. So this is uncommon producer output, but it is accepted by the profile and stays within the input budget.
Change and scope
The ordinals are pushed in a
for … ofloop instead of a spread call. Nothing else changes; the existing de-duplication ofincomplete_fact_recordsis untouched.Contribution scope: an ordinary decoder robustness fix within existing boundaries; a maintainer scope decision is not applicable.
Contract and boundary impact
decodeQlogCapture,src/browser/history/QlogCapture.ts.docs/public/product-catalog.json), package, or installation impact: none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/browser/history/QlogCapture.test.ts— "omits a hidden derived total for a stream with more contributions than call arguments allow" (about 0.7 s).94072364cthe new test fails withRangeError: Maximum call stack size exceeded.For evidence-bearing changes:
Validation performed
macOS (Apple silicon), Node 24.19.0.
npx vitest run src/browser/history/QlogCapture.test.ts -t "call arguments"on the base — fails with the RangeError above.npx vitest run src/browser/history/with the fix — 5 files, 100 tests passed.npm run build:cached && npx vitest run tests/acceptance/tools/qlogCapture.test.ts— 4 passed, 1 skipped.npm run typecheck— passed.npx oxfmt --checkandnpx oxlinton both changed files — passed, no errors.npm run verify:module-boundaries— passed.Compatibility, safety, and release
Before merge
type(scope): outcome.