Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
5cdb5e8 to
9600837
Compare
Recover the isolated effect metadata correction identified in #1669. Keep the generic annotation-algebra fixture independent of operation-specific effects. Co-authored-by: Pompilio Donato <238757198+pompiliodonatoapp@users.noreply.github.com>
9600837 to
579ecbd
Compare
Use one named input-schema projection for clients and catalog identity, preserve dialect declarations, and bound compact schema depth. Keep canonical SDK output validation when output advertisements are disabled. Release request-owned state on cancellation and carry upstream limitations through composed workflows. Preserve doctor full-output envelopes and validate navigation facts at their owner. Reviewed fixes: #2088, #2108, #2513, #2684, #2693, #2695, #2836, #2864, #2868, #2877, #2933, #2998, #3002, #3015. Validation: focused schema, SDK output-validation, context, and workflow tests passed; no schema dialect or canonical output validation was relaxed.
|
Heads up: main already has this change in 80de314. The code is in 🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
|
Thanks @morluto. Closing this PR as superseded by 80de3145e on The canonical process-launch effect and its fixture are already present on main; no distinct change remains. This is an unmerged closure: it does not label this PR as merged or remove contributor history/credit. The decision uses the current source diff and existing validation record; no new local test or provider run is claimed. |
binary_sessionchecks configured Android prerequisites, which can launchjava --list-modules. Its canonical effect declaration now recordslaunchesProcess: true, so the advertised MCP hints reportreadOnlyHint: falseandopenWorldHint: true.The existing annotation-algebra test now constructs a typed effect-free base and preserves its assertions. Scope is limited to canonical metadata and that fixture. This recovers the isolated correction from #1669, originally contributed by @pompiliodonatoapp; the commit retains contributor credit.
Validation: traced the production handler through Android availability and the Java launcher, inspected the annotation consumers, formatted the two changed files with pinned Node 24.18.0 and two formatter threads, and completed
git diff --check. Tests, typechecks, lint, builds, provider workloads and CI reruns were skipped at the maintainer's explicit request.