Skip to content

fix(mcp): declare binary session prerequisite process effects - #2864

Closed
morluto wants to merge 1 commit into
mainfrom
fix/recover-binary-session-process-effects
Closed

morluto wants to merge 1 commit into
mainfrom
fix/recover-binary-session-process-effects

Conversation

@morluto

@morluto morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

binary_session checks configured Android prerequisites, which can launch java --list-modules. Its canonical effect declaration now records launchesProcess: true, so the advertised MCP hints report readOnlyHint: false and openWorldHint: true.

The existing annotation-algebra test now constructs a typed effect-free base and preserves its assertions. Scope is limited to canonical metadata and that fixture. This recovers the isolated correction from #1669, originally contributed by @pompiliodonatoapp; the commit retains contributor credit.

Validation: traced the production handler through Android availability and the Java launcher, inspected the annotation consumers, formatted the two changed files with pinned Node 24.18.0 and two formatter threads, and completed git diff --check. Tests, typechecks, lint, builds, provider workloads and CI reruns were skipped at the maintainer's explicit request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:09:03.985858Z 579ecbd New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the metadata correction matches the prerequisite check.

Summary

Corrects binary_session metadata to declare that prerequisite checks can launch a process.

  • Binary session status now reports its process launch in MCP hints.

Reviews (4) · Last reviewed commit: "fix(mcp): declare binary session prerequ..." · Reviewed by Greptile

@morluto
morluto force-pushed the fix/recover-binary-session-process-effects branch 2 times, most recently from 5cdb5e8 to 9600837 Compare October 13, 2026 18:44
Recover the isolated effect metadata correction identified in #1669. Keep the generic annotation-algebra fixture independent of operation-specific effects.

Co-authored-by: Pompilio Donato <238757198+pompiliodonatoapp@users.noreply.github.com>
@morluto
morluto force-pushed the fix/recover-binary-session-process-effects branch from 9600837 to 579ecbd Compare October 13, 2026 19:07
@morluto morluto added area: mcp MCP server, transport, and tool registration bug Something isn't working labels Oct 14, 2026
morluto added a commit that referenced this pull request Oct 14, 2026
Use one named input-schema projection for clients and catalog identity, preserve dialect declarations, and bound compact schema depth. Keep canonical SDK output validation when output advertisements are disabled. Release request-owned state on cancellation and carry upstream limitations through composed workflows. Preserve doctor full-output envelopes and validate navigation facts at their owner.

Reviewed fixes: #2088, #2108, #2513, #2684, #2693, #2695, #2836, #2864, #2868, #2877, #2933, #2998, #3002, #3015.

Validation: focused schema, SDK output-validation, context, and workflow tests passed; no schema dialect or canonical output validation was relaxed.
@CassieFox23

Copy link
Copy Markdown
Contributor

Heads up: main already has this change in 80de314. The code is in src/contracts/toolEffects.ts. It is listed on tracker #3582. If this PR still adds something main doesn't have, please say so here and I'll take it off the list. Thanks for the fix!

🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊

@morluto

morluto commented Oct 18, 2026

Copy link
Copy Markdown
Owner Author

Thanks @morluto. Closing this PR as superseded by 80de3145e on main.

The canonical process-launch effect and its fixture are already present on main; no distinct change remains.

This is an unmerged closure: it does not label this PR as merged or remove contributor history/credit. The decision uses the current source diff and existing validation record; no new local test or provider run is claimed.

@morluto morluto closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: mcp MCP server, transport, and tool registration bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants