Skip to content

fix(setup): keep Devin configuration JSON-formatted - #2894

Closed
morluto wants to merge 3 commits into
mainfrom
cursor/restore-main-checks-1ffc
Closed

morluto wants to merge 3 commits into
mainfrom
cursor/restore-main-checks-1ffc

Conversation

@morluto

@morluto morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Summary

Current main does not pass the local typecheck or lint gate. The empty DSH_HOME fix also changed Devin's configuration format from json to devin, and two tests no longer typecheck or lint. This restores those checks without changing Devin's mcp_config.json behavior.

Problem and expected behavior

npm run check:fast fails on current main:

  • SupportedClients.ts declares format: "devin", which is not a member of SetupClient["format"], so tsc fails.
  • tests/boundary/mcp/ghidraInventoryMcp.test.ts imports join twice.
  • tests/boundary/cli/clientProfileLifecycle.test.ts passes a string | undefined directory into join under noUncheckedIndexedAccess.

Devin configuration remains JSON. The retained-skill test still checks both skill directories.

Change and scope

  • Restore Devin's format to json. The client name stays devin; the format names the file shape.
  • Remove the duplicate node:path import.
  • Give the retained skill directory pairs a const tuple so each directory stays a string.

Contribution scope fit: ordinary fix inside existing setup and test boundaries. Maintainer scope decision: not applicable.

Contract and boundary impact

  • Semantic owner and earliest changed stage: SupportedClients owns client format. The test edits stay in their existing tests.
  • Contribution scope fit and linked maintainer decision: not applicable.
  • CLI and MCP/tool-catalog contract: none.
  • Provider, bridge, target-format, or platform compatibility: Devin setup still writes mcp_config.json.
  • Evidence, artifact, provenance, or reconstruction contract: none.
  • Target selection, authority, upstream behavior, and cleanup details: not applicable.
  • Generated metadata: none.

Expected effects:

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: the retained-skill assertion is typed; no new behavior test. The Devin format change is a type-level restoration of the previous value.
  • Base reproduction: npm run check:fast failed on 855ed968 before these commits and passes after them.
  • User-visible CLI/MCP output: none.
  • Remaining proof gaps: no separate Devin setup run. The format value is the same string main had before af782dd5f.

Validation performed

  • npm run check:fast — typecheck and lint passed.
  • npm run test:focused -- tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts — 14 passed, on the branch that also contains the browser cancellation fix.

Compatibility, safety, and release

No breaking change. Devin registrations stay JSON.

Open in Web Open in Cursor 

The empty DSH_HOME fix also changed Devin's declared format to "devin", which is not a configuration format and stops the typecheck. Devin still writes mcp_config.json.
The inventory MCP test imported join twice, which fails lint on current main.
noUncheckedIndexedAccess treats the unlabeled pair list as an open array, so the directory passed to join was string or undefined.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T16:56:42.477623Z d5ec547 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Restores Devin’s configuration format to json and fixes two test compilation errors.

  • Devin setup keeps its configuration in JSON.
  • The CLI and Ghidra tests keep checking their existing behavior.

Reviews (1) · Last reviewed commit: "test(cli): type the retained skill direc..." · Reviewed by Greptile

@morluto

morluto commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

The Devin JSON-format fix and import cleanup are already on main through #2895 (df3d96da801976fdbe37a726c2f4f84af8ffbf90). The remaining tuple factoring has equivalent const typing in main, so this PR adds no distinct behavior. Closing the duplicate while preserving this branch and its original commits. Credit remains with @morluto and the original commit authors; #2895 retains the integrated source. Validation was source/ancestry comparison only; tests were not run.

@morluto morluto closed this Oct 13, 2026
@morluto morluto added bug Something isn't working area: setup Setup, packaging, upgrade, install, Doctor, and client registration labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: setup Setup, packaging, upgrade, install, Doctor, and client registration bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants