Repository navigation
Conversation
The empty DSH_HOME fix also changed Devin's declared format to "devin", which is not a configuration format and stops the typecheck. Devin still writes mcp_config.json.
The inventory MCP test imported join twice, which fails lint on current main.
noUncheckedIndexedAccess treats the unlabeled pair list as an open array, so the directory passed to join was string or undefined.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
The Devin JSON-format fix and import cleanup are already on main through #2895 ( |
Summary
Current
maindoes not pass the local typecheck or lint gate. The emptyDSH_HOMEfix also changed Devin's configuration format fromjsontodevin, and two tests no longer typecheck or lint. This restores those checks without changing Devin'smcp_config.jsonbehavior.Problem and expected behavior
npm run check:fastfails on currentmain:SupportedClients.tsdeclaresformat: "devin", which is not a member ofSetupClient["format"], sotscfails.tests/boundary/mcp/ghidraInventoryMcp.test.tsimportsjointwice.tests/boundary/cli/clientProfileLifecycle.test.tspasses astring | undefineddirectory intojoinundernoUncheckedIndexedAccess.Devin configuration remains JSON. The retained-skill test still checks both skill directories.
Change and scope
json. The client name staysdevin; the format names the file shape.node:pathimport.Contribution scope fit: ordinary fix inside existing setup and test boundaries. Maintainer scope decision: not applicable.
Contract and boundary impact
SupportedClientsowns client format. The test edits stay in their existing tests.mcp_config.json.Expected effects:
Evidence and regression coverage
npm run check:fastfailed on855ed968before these commits and passes after them.mainhad beforeaf782dd5f.Validation performed
npm run check:fast— typecheck and lint passed.npm run test:focused -- tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts— 14 passed, on the branch that also contains the browser cancellation fix.Compatibility, safety, and release
No breaking change. Devin registrations stay JSON.