Repository navigation
fix(reference): reconcile excluded symlink identities - #2907
Adkid-Zephyr wants to merge 11 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5eb1a004b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
acba6fa to
afcbce4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afcbce4925
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
afcbce4 to
ddcf37d
Compare
ddcf37d to
1786fdd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1786fdd001
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f097bcc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cd5f6c279
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…d-symlink # Conflicts: # docs/cli.md # src/application/ReferenceSourceImport.ts # src/domain/referenceSourceGraph.test.ts # src/domain/referenceSourceGraph.ts # src/domain/referenceSourcePathIdentity.ts # tests/boundary/cli/referenceSourceExclusions.test.ts # tests/boundary/filesystem/referenceSourceImport.test.ts
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
All reported review findings have been addressed on The final diff covers exact filesystem-kind consistency, exclusion applicability, and bounded component-prefix lookup. Local verification is recorded in the PR description. This is ready for your final maintainer review and merge when convenient. Thank you for the fixes and guidance along the way. |
|
Superseded by the delivered change on main: ec271121e. Reference-source exclusion handling verifies symlink target identity and applicability instead of treating unrelated path spellings as an exclusion match. Closing this earlier proposal. Current main qualification passed: https://github.com/morluto/rea/actions/runs/38690953281. |
|
Thanks @Adkid-Zephyr for checking how excluded symlinks retain their identity. Main includes the identity-preserving path handling. |
Summary
Fixes #2651. Thanks to @coygeek for the original report.
Validate excluded symlink targets without conflating distinct filesystem spellings or repeatedly walking and normalizing long path prefixes. Current main supplies the exclusion-kind metadata and missing-target handling; this PR preserves those behaviors and completes graph consistency and identity checks.
Problem and expected behavior
A source tree may contain an excluded directory
caféand a different filecafe\u0301. Their recorded filesystem identities must not be conflated when checking entry kinds. Symbolic-reference lookup can still use an unambiguous Unicode fallback.An internal target must also agree with the recorded facts: an escape is not an omission, an excluded file cannot establish subtree coverage, and directory evidence cannot contradict an inventoried file at the same exact path. Unknown kind remains unknown.
Change and scope
Contract and boundary impact
Expected operation effects:
Evidence and regression coverage
The original source-import failure and later review findings were reproduced before their corrections. Coverage includes distinct NFC/NFD filesystem names, exact kind conflicts, unknown kind, legacy omissions, directory descendants, escapes, mixed exclusion kinds, sibling boundaries, and source preservation.
A small 128-component query made 128 normalization calls with the original parent walker and one with the component index. This is a resource-work regression, not an end-to-end latency, token, CPU, or memory improvement claim.
Validation performed
Pinned Node 24.18.0 / npm 11.16.0; head
1092f12dincludes main500e3239and preserves maintainer commits:npm run test:focused— 139 passed, 3 skipped. One skip is the new Linux filesystem-coexistence test; its platform-independent graph regression passed locally.npm run check— passed, including architecture guards.npm run docs:check— passed, including 5 consistency tests.npm run verify:test-discovery— 1,244 files discovered exactly once.git diff --check— passed.The eight suites implicated in the preceding CI run were also rerun after incorporating upstream #3080 and the README-fact isolation fix: 117 passed (injected IDA protocol fixture, no real provider). The full suite and actual Linux coexistence case remain for current-head CI. Local test results do not claim CI or maintainer approval.
Compatibility, safety, and release
No new graph field relative to current main, provider, package entrypoint, or installation behavior. Static import remains read-only. Tests use self-created fixtures. Main's general exclusion-kind and missing-target behavior is retained rather than replaced by the earlier narrower representation.
Implementation, regression tests, conflict resolution, and self-review were assisted by OpenAI Codex.
Before merge
type(scope): outcome.