Skip to content

feat(analysis-view): report observed query parameter names - #2982

Merged
morluto merged 1 commit into
morluto:mainfrom
wunianze666-netizen:codex/api-query-parameter-names
Oct 13, 2026
Merged

morluto merged 1 commit into
morluto:mainfrom
wunianze666-netizen:codex/api-query-parameter-names

Conversation

@wunianze666-netizen

@wunianze666-netizen wunianze666-netizen commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem and resulting behavior

Historical API-surface views omit observed query parameter names. For /products?category=books&page=1 and /products?category=games&sort=price, callers currently have to inspect individual records to recover category, page and sort.

This adds opt-in view.include_query_parameter_names: true and per-group {name, record_ordinals} entries. Omitted/default requests keep their existing output, including the published default example.

Fixes #2913.

Implementation and scope

  • Share WHATWG form-query name decoding with browser URL inspection while preserving the recorded encoded path used for grouping.
  • Retain empty/Unicode names, decoded plus distinctions and caller-selected ordinal order; deduplicate a name's ordinal within one record.
  • Reserve query-parser scratch and admit complete group mutations before allocating retained names/ordinals. Query values and fragments are omitted from the inventory.
  • Preserve sensitive-parent refusals, original URLs, parent Evidence identity, coverage and existing inferred path-template semantics.
  • Update the authored skill reference and historical-capture guide. Generated catalogs, skills, native artifacts and local receipts remain uncommitted.

This is an existing static selected-view extension. It adds no provider, target execution, request replay, network acquisition or mutation authority. A separate maintainer provider/authority decision is not applicable.

Validation

On Windows x64 with pinned Node 24.18.0/npm 11.16.0, with the final implementation rebased onto main 0bc422d:

  • 38 source tests across API view, accumulator and browser URL inspection passed.
  • 11 compiled CLI boundary tests and 15 production MCP boundary tests passed, including new selected-query regressions and unchanged default-example reproduction.
  • docs:check passed, including 5 README consistency tests.
  • The complete npm run check passed: typecheck, lint, formatting, knip, metadata and architecture guards. Test discovery and git diff --check also passed.
  • The source checkout's missing Windows controls were supplied from the exact qualified npm 6.4.0 artifact/manifest pair; verify:windows-native:artifact passed. These ignored files are excluded from the PR.
  • A separate downstream client exercised actual production stdio MCP HAR inspection on two captures, consumed selected query-name Evidence, and matched exact groups/source SHA-256 with its independent HAR engine. The published npm 6.4.0 path was also verified separately for older-server compatibility.

No real Ghidra/Hopper/IDA or live browser-target investigation was needed or verified. No performance improvement is claimed; full-task agent tokens and process-family CPU/peak memory were not benchmarked. Representation-expansion and repeated-name resource regressions are covered.

Compatibility

The selection and output field are optional. Existing default views, Evidence examples, capture decoder profiles and source identities remain compatible. Query inventories establish observed names, not required parameters, value types, complete server schemas or handler identity.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:00:31.517046Z f73ea13 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no actionable defects or applicable rule violations were found.

Summary

Adds optional include_query_parameter_names to historical API-surface views. Selected groups report decoded names and their source record ordinals.

  • API-surface groups can show observed query names and their source records.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[CLI or MCP selected view] --> B[Resolve parent Evidence]
  B --> C{Supported HAR and no sensitive declarations?}
  C -->|No| D[Refuse projection]
  C -->|Yes| E[Read recorded origin and path]
  E --> F{Query names selected?}
  F -->|No| G[Existing group output]
  F -->|Yes| H[Reserve parsing work and decode names]
  H --> I[Deduplicate names within each record]
  I --> J[Admit complete group change]
  J --> K[Return sorted names with source ordinals]
Loading

Reviews (2) · Last reviewed commit: "feat(analysis-view): report observed que..." · Reviewed by Greptile

@wunianze666-netizen
wunianze666-netizen force-pushed the codex/api-query-parameter-names branch from e00f9ac to f73ea13 Compare October 13, 2026 18:54
@morluto
morluto merged commit dd36b4a into morluto:main Oct 13, 2026
1 check passed
@morluto morluto added the enhancement New feature or request label Oct 14, 2026
@morluto morluto mentioned this pull request Oct 14, 2026
3 tasks done
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

@wunianze666-netizen, welcome to REA! Thanks for adding observed query parameter names with their source record ordinals. Analysts can follow those names back to the captured requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Report observed query parameter names in API surfaces

2 participants