Skip to content

fix(cli): name both recorded-core architectures in the path contract - #3234

Closed
fengqiaoqu wants to merge 1 commit into
morluto:mainfrom
fengqiaoqu:codex/issue-3167-recorded-crash-help
Closed

fengqiaoqu wants to merge 1 commit into
morluto:mainfrom
fengqiaoqu:codex/issue-3167-recorded-crash-help

Conversation

@fengqiaoqu

Copy link
Copy Markdown

Problem

inspect-recorded-crash decodes both supported Linux core profiles — x86_64-little-endian (machine 62) and aarch64-little-endian (machine 183) — and the MCP tool contract already says "Linux ELF64 amd64 or AArch64 little-endian core". The CLI path argument still described only Local Linux amd64 ELF core (#3167), so the CLI help and exported schema omitted the documented AArch64 support that PR #2505 added.

Fix

Align the CLI path description with the MCP contract wording: Local Linux ELF64 amd64 or AArch64 little-endian core. No decoder, acceptance, or option behavior changes.

Validation

  • New CLI boundary test tests/boundary/cli/recordedCrashHelpArchitectures.test.ts exports the command schema via --schema --json and asserts the path description names both amd64 and AArch64. It fails before the fix and passes after.
  • npm run check:fast passes.

Fixes #3167

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low impact] Updates help text for a diagnostic command.

The PR appears safe to merge, with a non-blocking suggestion to reuse the shared CLI test helper.

Findings

  1. P2 CLI test setup is duplicated ▶
Fix with agent prompt
### Issue 1
tests/boundary/cli/recordedCrashHelpArchitectures.test.ts:7-23
The new `serve` helper repeats the output and exit-code capture already provided by `serveCli` in `cliServeHarness.ts`. Future changes to the shared setup would need to be repeated here. Import `serveCli` and pass the command arguments directly instead.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Updates the CLI path description to name both supported core architectures.

  • The crash command’s path help names both core architectures.

Reviews (1) · Last reviewed commit: "fix(cli): name both recorded-core archit..." · Reviewed by Greptile

Comment on lines +7 to +23
const serve = async (
cli: CliInstance,
argv: readonly string[],
): Promise<{ readonly stdout: string; readonly exitCode: number }> => {
let stdout = "";
let exitCode = 0;
await cli.serve([...argv], {
env: {},
exit: (code) => {
exitCode = code;
},
stdout: (text) => {
stdout += text;
},
});
return { stdout, exitCode };
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CLI test setup is duplicated

The new serve helper repeats the output and exit-code capture already provided by serveCli in cliServeHarness.ts. Future changes to the shared setup would need to be repeated here. Import serveCli and pass the command arguments directly instead.

Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/boundary/cli/recordedCrashHelpArchitectures.test.ts
Line: 7-23

Comment:
**CLI test setup is duplicated**

The new `serve` helper repeats the output and exit-code capture already provided by `serveCli` in `cliServeHarness.ts`. Future changes to the shared setup would need to be repeated here. Import `serveCli` and pass the command arguments directly instead.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@morluto

morluto commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

This PR's behavior is now published on main (8dde637) in 7df85f16a. Thanks @fengqiaoqu for the CLI help correction and regression proposal.

Covered scope: Recorded-crash help names Linux ELF64 amd64 and AArch64 little-endian core paths already admitted by the provider.

Main evidence: tests/boundary/binaryDiagnostics/recordedCrashProvider.test.ts; tests/boundary/mcp/recordedCrashMcp.test.ts.

Validation limits: Documentation/help change only; no claim that every core subtype or architecture is accepted.

I checked the current published source and the substantive review threads; no unique behavior or dependency change remains on this PR. Closing as superseded without resolving individual review threads.

@morluto morluto closed this Oct 14, 2026
@morluto morluto added bug Something isn't working area: cli CLI adapter and one-shot commands labels Oct 14, 2026
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

@fengqiaoqu, thank you for catching the recorded-crash help omitting AArch64 and for supplying the CLI schema regression. Main names both supported core architectures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cli CLI adapter and one-shot commands bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Recorded-crash CLI help and schema omit documented AArch64 support

3 participants