Added option for increasing the connection timeout of the aws-sdk in deploy step #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
requested changes
Oct 12, 2016
README.md
Outdated
| -A, --packageDirectory [] Local package directory | ||
| -x, --excludeGlobs [] Add a space separated list of file(type)s to ignore (e.g. "*.json .env") | ||
| -D, --prebuiltDirectory [] Prebuilt directory | ||
| -T, --deployTimeout [120000] Deploy Timeout |
There was a problem hiding this comment.
maybe mention that this is Upload to AWS: timeout in ms.
bin/node-lambda
Outdated
| .option('-x, --excludeGlobs [' + EXCLUDE_GLOBS + ']', | ||
| 'Space-separated glob pattern(s) for additional exclude files (e.g. "event.json dotenv.sample")', EXCLUDE_GLOBS) | ||
| .option('-D, --prebuiltDirectory [' + PREBUILT_DIRECTORY + ']', 'Prebuilt directory', PREBUILT_DIRECTORY) | ||
| .option('-T, --deployTimeout [' + DEPLOY_TIMEOUT + ']', 'Deploy Timeout', DEPLOY_TIMEOUT) |
| region: 'us-east-1,us-west-2,eu-west-1', | ||
| eventFile: 'event.json', | ||
| contextFile: 'context.json', | ||
| deployTimeout: 120000, |
There was a problem hiding this comment.
was expecting a test to see if aws.config.httpOptions.timeout is correctly set
DeviaVir
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the packaged .zip is quite big, it takes some time to upload it to AWS Lambda. If it takes longer than the default 120000ms it results in a connection timeout error. With this additional option, the timeout can be extended if needed.