Skip to content

Removed event_sources.json#204

Merged
DeviaVir merged 2 commits into
motdotla:masterfrom
abetomo:fix_remove_event_sources_json
Mar 27, 2017
Merged

Removed event_sources.json#204
DeviaVir merged 2 commits into
motdotla:masterfrom
abetomo:fix_remove_event_sources_json

Conversation

@abetomo

@abetomo abetomo commented Mar 27, 2017

Copy link
Copy Markdown
Contributor
  • Removed event_sources.json of the project root(The same file is in lib.)
  • Removed unneeded space in lib/main.js

@DeviaVir DeviaVir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 keep up the good (cleaning) work

@DeviaVir DeviaVir merged commit 18d9300 into motdotla:master Mar 27, 2017
@limenutt

Copy link
Copy Markdown

@abetomo I think this change has lead to the following error during deployment using 0.8.14
Error: ENOENT: no such file or directory, open 'event_sources.json'

at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.readFileSync (/tmp/src129258341/src/node_modules/node-lambda/node_modules/fs-extra/node_modules/jsonfile/index.js:66:20)
at Lambda._eventSourceList (/tmp/src129258341/src/node_modules/node-lambda/lib/main.js:141:28)
at /tmp/src129258341/src/node_modules/node-lambda/lib/main.js:561:33
at /tmp/src129258341/src/node_modules/node-lambda/lib/main.js:273:5

@abetomo

abetomo commented Mar 27, 2017

Copy link
Copy Markdown
Contributor Author

@limenutt Have you run node-lambda setup ?

@abetomo

abetomo commented Mar 27, 2017

Copy link
Copy Markdown
Contributor Author

event_sources.json is a file to be installed in the project root of each user.
(It will also be created in node-lambda setup)

That is, it is unnecessary for root of the node-lambda project.

@limenutt

limenutt commented Mar 27, 2017

Copy link
Copy Markdown

No I haven't run node_lambda setup with the new version. What happened is that one of my ci tasks failed to build and deploy lambda function because new version has been published with the change. I think that if I understand semver correctly, you should have incremented the minor version of the package with this update, since it could be a breaking change. Patch version updates are reserved for bugfixes only.

@abetomo

abetomo commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

I was troubled with the same trouble so I tried opening the following PR.
#205

@DeviaVir DeviaVir mentioned this pull request Mar 28, 2017
@abetomo abetomo deleted the fix_remove_event_sources_json branch March 29, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants