Skip to content

Bugfix InvalidParameterValueException is given when createFunction #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeviaVir merged 4 commits into from
Mar 29, 2017
Merged

Bugfix InvalidParameterValueException is given when createFunction #209

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c9b7df
Bugfix InvalidParameterValueException is given when createFunction
abetomo Mar 29, 2017
ecdd09b
Fix use the empty string as a value, so I checked undefined
abetomo Mar 29, 2017
bf6c86e
Fix to undefined check
abetomo Mar 29, 2017
851188a
Remove AWS_DLQ_TARGET_ARN from example file
abetomo Mar 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix use the empty string as a value, so I checked undefined
  • Loading branch information
@abetomo
abetomo committed Mar 29, 2017
commit ecdd09bd4e0d3a6df5e933d14b40ec6b2a02cbad
8 changes: 7 additions & 1 deletion bin/node-lambda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,18 @@ var AWS_PUBLISH = process.env.AWS_PUBLISH || false;
var AWS_FUNCTION_VERSION = process.env.AWS_FUNCTION_VERSION || '';
var AWS_VPC_SUBNETS = process.env.AWS_VPC_SUBNETS || '';
var AWS_VPC_SECURITY_GROUPS = process.env.AWS_VPC_SECURITY_GROUPS || '';
var AWS_DLQ_TARGET_ARN = process.env.AWS_DLQ_TARGET_ARN || '';
var EVENT_FILE = process.env.EVENT_FILE || 'event.json';
var PACKAGE_DIRECTORY = process.env.PACKAGE_DIRECTORY;
var CONTEXT_FILE = process.env.CONTEXT_FILE || 'context.json';
var PREBUILT_DIRECTORY = process.env.PREBUILT_DIRECTORY || '';
var DEPLOY_ZIPFILE = process.env.DEPLOY_ZIPFILE || '';
var AWS_DLQ_TARGET_ARN = (function() {
// You can clear the setting by passing an empty string
// when executing updateFunctionConfiguration
if (process.env.AWS_DLQ_TARGET_ARN !== undefined)
return process.env.AWS_DLQ_TARGET_ARN
return undefined;
})();

program
.command('deploy')
Expand Down