Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding Artifactory integration + debug
  • Loading branch information
macaab26 committed Mar 17, 2025
commit b89fd186015b4e91e9fb938ff2c57e06ff6280fe
5 changes: 4 additions & 1 deletion .github/workflows/lumigator_pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,14 @@ jobs:

- name: Spinning up containers for the tests
if: steps.filter.outputs.test == 'true' || contains(github.ref, 'refs/tags/')
run: ENABLE_FIRST_TIME_CACHE=false make start-lumigator-build
run: CI=true HF_TOKEN=${{ secrets.JF_ACCESS_TOKEN }} HF_ENDPOINT=${{ secrets.JF_URL_HF }} ENABLE_FIRST_TIME_CACHE=false make start-lumigator-build

- name: Configure 'default' test environment variables
run: ./scripts/set_env_vars.sh

- name: Debug w/ tmate
uses: mxschmitt/action-tmate@v3

- name: Run ${{ matrix.test }} integration tests
if: steps.filter.outputs.test == 'true' || contains(github.ref, 'refs/tags/')
run: make test-${{ matrix.test }}-integration
Expand Down
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ RAY_WORKER_GPUS ?= 0
RAY_WORKER_GPUS_FRACTION ?= 0.0
GPU_COMPOSE :=
MODEL_CACHE_COMPOSE :=
CI_COMPOSE :=
export SQLALCHEMY_DATABASE_URL ?= sqlite:////tmp/local.db

DEBUGPY_ARGS :=
Expand Down Expand Up @@ -64,6 +65,11 @@ ifneq ($(ENABLE_FIRST_TIME_CACHE), false)
MODEL_CACHE_COMPOSE := -f docker-compose.model-cache.override.yaml
endif

ifeq ($(CI), true)
@echo "HF_TOKEN=$(HF_TOKEN)" >> $(CONFIG_DEFAULT_FILE)
@echo "HF_ENDPOINT=$(HF_ENDPOINT)" >> $(CONFIG_DEFAULT_FILE)
CI_COMPOSE := -f docker-compose.ci.override.yaml
endif

# lumigator runs on a set of containers (backend, ray, minio, etc).
# The following allows one to start all of them before calling a target
Expand Down Expand Up @@ -148,7 +154,7 @@ start-lumigator: config-generate-env

# Launches lumigator with no code mounted in, and forces build of containers (used in CI for integration tests)
start-lumigator-build: config-generate-env
RAY_ARCH_SUFFIX=$(RAY_ARCH_SUFFIX) ARCH=${ARCH} COMPUTE_TYPE=$(COMPUTE_TYPE) docker compose --env-file "$(CONFIG_BUILD_DIR)/.env" --profile local $(GPU_COMPOSE) $(MODEL_CACHE_COMPOSE) -f $(LOCAL_DOCKERCOMPOSE_FILE) up -d --build
RAY_ARCH_SUFFIX=$(RAY_ARCH_SUFFIX) ARCH=${ARCH} COMPUTE_TYPE=$(COMPUTE_TYPE) docker compose --env-file "$(CONFIG_BUILD_DIR)/.env" --profile local $(CI_COMPOSE) $(GPU_COMPOSE) $(MODEL_CACHE_COMPOSE) -f $(LOCAL_DOCKERCOMPOSE_FILE) up -d --build

# Launches lumigator with no code mounted in, and forces build of containers (used in CI for integration tests)
start-lumigator-build-postgres: config-generate-env
Expand Down
10 changes: 10 additions & 0 deletions docker-compose.ci.override.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
services:
ray:
environment:
- HF_TOKEN
- HF_ENDPOINT

backend:
environment:
- HF_TOKEN
- HF_ENDPOINT
Loading