Skip to content

Conversation

@peteski22
Copy link
Contributor

What's changing

  • Fix fstring for log entry
  • update docstring
  • rename s3 fs vars

If this PR is related to an issue or closes one, please link it here.

How to test it

Steps to test the changes:

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@peteski22 peteski22 requested a review from njbrake March 20, 2025 17:31
@peteski22 peteski22 enabled auto-merge (squash) March 20, 2025 17:31
Copy link
Contributor

@njbrake njbrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteski22 peteski22 mentioned this pull request Mar 21, 2025
4 tasks
@peteski22 peteski22 merged commit 2a089e2 into main Mar 21, 2025
19 checks passed
@peteski22 peteski22 deleted the service/jobs/fix-fstring branch March 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants