Update schemas, align job results S3 paths, refactor inference metrics calc #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njbrake
reviewed
Mar 20, 2025
Contributor
njbrake
left a comment
njbrake
left a comment
There was a problem hiding this comment.
I'm interested to understand why the change to setting optional values as 0: it seems like it may quietly ignore errors by setting defaults when missing, instead of explicitly checking for values that are missing.
peteski22
commented
Mar 25, 2025
njbrake
approved these changes
Mar 26, 2025
Contributor
njbrake
left a comment
njbrake
left a comment
There was a problem hiding this comment.
A few scope-creepy type comments but overall looks great. Thank you for the improvements!
peteski22
force-pushed
the
jobs/inference/run_inference-minor-tweaks
branch
2 times, most recently
from
7429631 to
bdce671
Compare
github-actions
bot
added
the
schemas
… don't want to allow it anyway
* Extract calculate averages function and test * Fix schema
…ts for post-processing to add URL
peteski22
force-pushed
the
jobs/inference/run_inference-minor-tweaks
branch
from
3103e65 to
e39303e
Compare
peteski22
changed the title
peteski22
force-pushed
the
jobs/inference/run_inference-minor-tweaks
branch
from
e39303e to
e850c1a
Compare
…orage paths * Adjust 'jobs' schemas (JobOutput) to allow missing (and None) metrics * Sanitize S3 filename to prevent forward slashes and other awkward characters * Inference and Evaluation jobs updated (mostly based on S3 tweaks)
peteski22
force-pushed
the
jobs/inference/run_inference-minor-tweaks
branch
from
e850c1a to
a2a790f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
InferenceJobOutput,InferenceMetrics,PredictionResultandJobOutputwithinjobs/How to test it
Steps to test the changes:
Additional notes for reviewers
Anything you'd like to add to help the reviewer understand the changes you're proposing.
I already...
/docs)