Skip to content

Bugfix FXIOS-10490 [Toolbar redesign] Unable to perform search from the navigation toolbar (backport #22994)#23015

Merged
thatswinnie merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-22994
Nov 11, 2024
Merged

Bugfix FXIOS-10490 [Toolbar redesign] Unable to perform search from the navigation toolbar (backport #22994)#23015
thatswinnie merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-22994

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 11, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Fixes bug where searching for a search term wouldn't leave overlay mode. Also fixes suggestions not being shown when pasting a search term.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #22994 done by [Mergify](https://mergify.com).

@thatswinnie @mergify
Bugfix FXIOS-10490 [Toolbar redesign] Unable to perform search from t…
c9ebc89 
…he navigation toolbar (#22994)

* Enter overlay mode correctly if needed

* Show suggestions when a search term is pasted

(cherry picked from commit e7d4e11)
@mergify mergify Bot requested a review from a team as a code owner November 11, 2024 09:29
@mergify mergify Bot requested review from ih-codes and removed request for a team November 11, 2024 09:29
@mergify mergify Bot mentioned this pull request Nov 11, 2024
Merged
6 tasks
@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented Nov 11, 2024

Messages
📖 Project coverage: 32.62%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.62

File Coverage
AddressToolbarContainer.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against c9ebc89

@thatswinnie thatswinnie merged commit 89694d5 into release/v133 Nov 11, 2024
@thatswinnie thatswinnie deleted the mergify/bp/release/v133/pr-22994 branch November 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

@ih-codes ih-codes Awaiting requested review from ih-codes ih-codes is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mobiletest-ci-bot @thatswinnie