Conversation
ih-codes
commented
Nov 14, 2024
| 5A31275828906422001F30FA /* BookmarksDelegateMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5A31275728906422001F30FA /* BookmarksDelegateMock.swift */; }; | ||
| 5A32C2B62AD8517200A9B5A4 /* MetricKitWrapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5A32C2B52AD8517200A9B5A4 /* MetricKitWrapper.swift */; }; | ||
| 5A37861429A2BFB9006B3A34 /* Common in Frameworks */ = {isa = PBXBuildFile; productRef = 5A37861329A2BFB9006B3A34 /* Common */; }; | ||
| 5A37861929A2C337006B3A34 /* Sentry in Frameworks */ = {isa = PBXBuildFile; productRef = 5A37861829A2C337006B3A34 /* Sentry */; }; |
Collaborator
Author
There was a problem hiding this comment.
@OrlaM Seems like I was able to successfully compile Firefox and Focus after removing a few extra Sentry framework links, so those must have been unnecessary.
Generated by 🚫 Danger Swift against 6861575 |
MattLichtenstein
approved these changes
Nov 14, 2024
Collaborator
|
@Mergifyio backport release/v133 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
… framework for Firefox for iOS and Focus (#23142) * Upgrade Firefox for iOS Sentry to 8.36.0 and switch to Sentry-Dynamic framework. * Upgrade Focus Sentry to 8.36.0 and switch to Sentry-Dynamic framework. (cherry picked from commit eb15e27) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj
6 tasks
DonalMe
pushed a commit
that referenced
this pull request
Nov 28, 2024
… framework for Firefox for iOS and Focus (backport #23142) (#23334) * Add FXIOS-10570 Upgrade Sentry to 8.36.0 and switch to Sentry-Dynamic framework for Firefox for iOS and Focus (#23142) * Upgrade Firefox for iOS Sentry to 8.36.0 and switch to Sentry-Dynamic framework. * Upgrade Focus Sentry to 8.36.0 and switch to Sentry-Dynamic framework. (cherry picked from commit eb15e27) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj * Resolve merge conflicts. --------- Co-authored-by: Isabella <ihugel@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Upgrade Sentry to 8.36.0 and switch to Sentry-Dynamic framework for Firefox for iOS and Focus as per instructions from Sentry.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)