Refactor FXIOS-10645 Update Bitrise to use XCode 16.1 by OrlaM · Pull Request #23211 · mozilla-mobile/firefox-ios

OrlaM · 2024-11-18T20:48:35Z

📜 Tickets

Jira ticket
Github issue

💡 Description

Updating Bitrise to use XCode 16.1

📝 Checklist

You have to check all boxes before merging

Filled in the above information (tickets numbers and description of your work)
Updated the PR name to follow our PR naming guidelines
Wrote unit tests and/or ensured the tests suite is passing
When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
If needed, I updated documentation / comments for complex code and public methods
If needed, added a backport comment (example @Mergifyio backport release/v120)

clarmso · 2024-11-19T00:09:04Z

Both Firefox and Focus fail on the swift run step. 😞

./content_blocker_update.sh: line 17:  6485 Killed: 9               swift run

I have mentioned the same issue for Xcode 16.0: #22449

clarmso · 2024-11-20T20:52:07Z

-(cd BrowserKit && swift run)
+cd BrowserKit
+swift run || true
+swift run


This workaround works on Github Actions as well. 🎉

isabelrios · 2024-11-21T10:59:21Z

Looks like there are 16 Unit Tests failures, some of those crashed. UI tests have not run in Bitrise yet until the unit tests pass

mobiletest-ci-bot · 2024-11-21T19:12:36Z

	Messages
📖	Edited 18 files
📖	Created 0 files

Generated by 🚫 Danger Swift against 4683e73

OrlaM · 2024-11-21T20:22:58Z

We have a green build 🙌

OrlaM · 2024-11-21T20:24:06Z

@mdotb-moz or @clarmso I can merge this as soon as I get the ok from the automation side.

OrlaM · 2024-11-21T21:11:33Z

@Mergifyio backport release/v133

mergify · 2024-11-21T21:11:41Z

backport release/v133

✅ Backports have been created

Details

#23332 Refactor FXIOS-10645 Update Bitrise to use XCode 16.1 (backport #23211) has been created for branch release/v133

isabelrios · 2024-11-22T09:08:57Z

We may need the fix in this PR here so that the failing test passes

mdotb-moz

LGTM

* Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <lmarceau@mozilla.com> Co-authored-by: Clare So <cso@mozilla.com> Co-authored-by: mbarone <mbarone@mozilla.com> (cherry picked from commit d356717)

* Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <lmarceau@mozilla.com> Co-authored-by: Clare So <cso@mozilla.com> Co-authored-by: mbarone <mbarone@mozilla.com>

* Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <lmarceau@mozilla.com> Co-authored-by: Clare So <cso@mozilla.com> Co-authored-by: mbarone <mbarone@mozilla.com> (cherry picked from commit d356717)

… (#23332) Refactor FXIOS-10645 Update Bitrise to use XCode 16.1 (#23211) * Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <lmarceau@mozilla.com> Co-authored-by: Clare So <cso@mozilla.com> Co-authored-by: mbarone <mbarone@mozilla.com> (cherry picked from commit d356717) Co-authored-by: OrlaM <omitchell@mozilla.com>

* Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <lmarceau@mozilla.com> Co-authored-by: Clare So <cso@mozilla.com> Co-authored-by: mbarone <mbarone@mozilla.com>

OrlaM added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 18, 2024

OrlaM requested a review from a team as a code owner November 18, 2024 20:48

OrlaM requested a review from jjSDET November 18, 2024 20:48

OrlaM requested a review from a team as a code owner November 19, 2024 15:36

clarmso requested review from clarmso and mdotb-moz November 19, 2024 16:00

clarmso reviewed Nov 20, 2024

View reviewed changes

OrlaM removed the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 21, 2024

OrlaM changed the title ~~Refactor Update Bitrise to use XCode 16.1~~ Refactor FXIOS-10645 Update Bitrise to use XCode 16.1 Nov 21, 2024

OrlaM and others added 13 commits November 22, 2024 09:18

Update Bitrise to use XCode 16.1

a608882

Update npm vulnrability

af8be0c

Add verbose to the swift command

b234e90

Try edge version

6410e22

Trying one thing

ab3f154

Update error handling in script

8bd0a05

Remove edge version

46b634d

Run script twice

e6222e6

Update focus

1f063f1

Revert npm change

657224d

Test remove shard script

b743dfa

Fix unit tests

5238bec

Update simulator target

87048a1

OrlaM and others added 14 commits November 22, 2024 09:18

Change simulator

05390ea

Disable some tests

ca0671e

Compile and test Focus on Github Actions

7dd0200

Use macos-15 runner

66feac1

Run Focus tests for supported iOS versions

62eb330

Revert to old workflow name

4310ab9

Update workflow name

5b7b002

Run Firefox smoke tests on Github Actions

a639c6e

Could the device matter?

0007974

Disable some more tests

759d02b

Update danger version

f89121e

Update package

199a5a6

How about iPad mini

5039752

How about using Github Actions to run old iOS versions?

4939a18

OrlaM force-pushed the om/bitrise-xcode-16 branch from 0ff2a3f to 4939a18 Compare November 22, 2024 14:19

OrlaM had a problem deploying to github-pages November 22, 2024 14:19 — with GitHub Actions Failure

Remove the update address from the smoke test

4683e73

mdotb-moz approved these changes Nov 22, 2024

View reviewed changes

OrlaM merged commit d356717 into main Nov 22, 2024

OrlaM deleted the om/bitrise-xcode-16 branch November 22, 2024 17:59

mergify Bot mentioned this pull request Nov 22, 2024

Refactor FXIOS-10645 Update Bitrise to use XCode 16.1 (backport #23211) #23332

Merged

6 tasks

lmarceau mentioned this pull request Nov 26, 2024

Bugfix FXIOS-10642 #23292 Fix Siteimageview ImageHandlerTests #23410

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor FXIOS-10645 Update Bitrise to use XCode 16.1#23211

Refactor FXIOS-10645 Update Bitrise to use XCode 16.1#23211
OrlaM merged 28 commits intomainfrom
om/bitrise-xcode-16

OrlaM commented Nov 18, 2024

Uh oh!

clarmso commented Nov 19, 2024 •

edited

Loading

Uh oh!

clarmso Nov 20, 2024

Uh oh!

isabelrios commented Nov 21, 2024 •

edited

Loading

Uh oh!

mobiletest-ci-bot commented Nov 21, 2024 •

edited

Loading

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

mergify Bot commented Nov 21, 2024 •

edited

Loading

Uh oh!

isabelrios commented Nov 22, 2024

Uh oh!

mdotb-moz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

OrlaM commented Nov 18, 2024

📜 Tickets

💡 Description

📝 Checklist

Uh oh!

clarmso commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarmso Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

isabelrios commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mobiletest-ci-bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

OrlaM commented Nov 21, 2024

Uh oh!

mergify Bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

isabelrios commented Nov 22, 2024

Uh oh!

mdotb-moz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

clarmso commented Nov 19, 2024 •

edited

Loading

isabelrios commented Nov 21, 2024 •

edited

Loading

mobiletest-ci-bot commented Nov 21, 2024 •

edited

Loading

mergify Bot commented Nov 21, 2024 •

edited

Loading