Skip to content

Bugfix FXIOS-10335 Fix audio/video leak after closing tab (backport #23213)#23243

Merged
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23213
Nov 20, 2024
Merged

Bugfix FXIOS-10335 Fix audio/video leak after closing tab (backport #23213)#23243
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23213

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 19, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

⚠️ For additional notes please see the linked Jira. This is a quick initial fix. I'm hoping to get extra eyes and regression testing on this. We are also still leaking a Tab object however I believe we can live with that if needed for v133, the critical leak is the WKWebView which causes audio/video for closed tabs to continue playing.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23213 done by [Mergify](https://mergify.com).

@mattreaganmozilla @mergify
Bugfix FXIOS-10335 Fix audio/video leak after closing tab (#23213)
02f79f4 
[FXIOS-10335] Initial attempt at fixing a leak of WKWebView and also a blank homepage bug that regressed as a result.

(cherry picked from commit a79edd2)
@mergify mergify Bot requested a review from a team as a code owner November 19, 2024 21:52
@mergify mergify Bot requested review from ih-codes and removed request for a team November 19, 2024 21:52
@mergify mergify Bot mentioned this pull request Nov 19, 2024
Merged
6 tasks
@mattreaganmozilla
Copy link
Copy Markdown
Collaborator

mattreaganmozilla commented Nov 19, 2024

cc @DonalMe

@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented Nov 19, 2024

Messages
📖 Project coverage: 31.9%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.67

File Coverage
BrowserViewController.swift 4.66% ⚠️

Generated by 🚫 Danger Swift against 02f79f4

DonalMe
DonalMe approved these changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DonalMe DonalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 133.0 RC2

@DonalMe DonalMe merged commit a337266 into release/v133 Nov 20, 2024
@DonalMe DonalMe deleted the mergify/bp/release/v133/pr-23213 branch November 20, 2024 20:58
@lmarceau lmarceau mentioned this pull request Nov 29, 2024
Merged
6 tasks
@mergify mergify Bot mentioned this pull request Dec 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonalMe DonalMe DonalMe approved these changes

@mattreaganmozilla mattreaganmozilla mattreaganmozilla approved these changes

@ih-codes ih-codes Awaiting requested review from ih-codes ih-codes is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattreaganmozilla @mobiletest-ci-bot @DonalMe