Skip to content

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. (backport #23308)#23310

Merged
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23308
Dec 3, 2024
Merged

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. (backport #23308)#23310
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23308

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Fixed tableView margins and section headers height

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #23308 done by [Mergify](https://mergify.com).

…ns/islands in the menu. (#23308)

FXIOS-10569 #23140 ⁃ [Menu Redesign] Fix the margin and Padding for the sections/islands in the menu.

(cherry picked from commit 97d6161)
@mergify mergify Bot requested a review from a team as a code owner November 22, 2024 10:53
@mergify mergify Bot requested review from mdotb-moz and removed request for a team November 22, 2024 10:53
@dicarobinho dicarobinho added the weekly-release Tagging backports for rapid release label Nov 22, 2024
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 31.99%
📖 Edited 2 files
📖 Created 0 files

MenuKit: Coverage: 40.52

File Coverage
MenuMainView.swift 51.61%
MenuTableView.swift 44.19% ⚠️

Generated by 🚫 Danger Swift against 0b61555

Copy link
Copy Markdown
Contributor

@DonalMe DonalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 133.1

@DonalMe DonalMe merged commit 9a64a7e into release/v133 Dec 3, 2024
@DonalMe DonalMe deleted the mergify/bp/release/v133/pr-23308 branch December 3, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

weekly-release Tagging backports for rapid release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants