Skip to content

Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapping on button#23312

Merged
PARAIPAN9 merged 2 commits intomainfrom
sparaipan/fxios-10500-Menu-not-displayed-after-tapping-on-button
Nov 22, 2024
Merged

Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapping on button#23312
PARAIPAN9 merged 2 commits intomainfrom
sparaipan/fxios-10500-Menu-not-displayed-after-tapping-on-button

Conversation

@PARAIPAN9
Copy link
Copy Markdown
Contributor

@PARAIPAN9 PARAIPAN9 commented Nov 22, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • This PR implements a caching mechanism for all the toolbar buttons in the getToolbarButton method.
  • It includes unit tests also.

Video

video.mov

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner November 22, 2024 11:29
@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented Nov 22, 2024 •
edited
Loading

Messages
📖 Edited 2 files
📖 Created 1 files

Generated by 🚫 Danger Swift against c0c50a3

@PARAIPAN9 PARAIPAN9 added the weekly-release Tagging backports for rapid release label Nov 22, 2024
@PARAIPAN9
Copy link
Copy Markdown
Contributor Author

PARAIPAN9 commented Nov 22, 2024

@Mergifyio backport release/v133

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 22, 2024 •
edited
Loading

backport release/v133

✅ Backports have been created

Details

@PARAIPAN9 PARAIPAN9 merged commit dbf8108 into main Nov 22, 2024
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-10500-Menu-not-displayed-after-tapping-on-button branch November 22, 2024 20:24
mergify Bot pushed a commit that referenced this pull request Nov 22, 2024
@PARAIPAN9 @mergify
Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapp…
81d1558 
…ing on button (#23312)

(cherry picked from commit dbf8108)
@mergify mergify Bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
clarmso pushed a commit that referenced this pull request Nov 25, 2024
@PARAIPAN9 @clarmso
Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapp…
b49cb53 
…ing on button (#23312)
isabelrios pushed a commit that referenced this pull request Dec 3, 2024
@PARAIPAN9 @isabelrios
Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapp…
a445acf 
…ing on button (#23312)
DonalMe pushed a commit that referenced this pull request Dec 3, 2024
@mergify @PARAIPAN9
Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapp…
c064754 
…ing on button (backport #23312) (#23338)

Bugfix FXIOS-10500 - [Toolbar Redesign] Menu not displayed after tapping on button (#23312)

(cherry picked from commit dbf8108)

Co-authored-by: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees

No one assigned

Labels

weekly-release Tagging backports for rapid release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PARAIPAN9 @mobiletest-ci-bot @thatswinnie