Skip to content

Refactor FXIOS-10647 Remove crash alert (backport #23300)#23329

Merged
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23300
Dec 3, 2024
Merged

Refactor FXIOS-10647 Remove crash alert (backport #23300)#23329
DonalMe merged 1 commit intorelease/v133from
mergify/bp/release/v133/pr-23300

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Remove the restore tabs alert

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #23300 done by [Mergify](https://mergify.com).

* Remove crash alert

* Remove commented code

(cherry picked from commit 81f3240)
@mergify mergify Bot requested a review from a team as a code owner November 22, 2024 16:54
@mergify mergify Bot requested review from issammani and removed request for a team November 22, 2024 16:54
@mergify mergify Bot mentioned this pull request Nov 22, 2024
6 tasks
@OrlaM OrlaM added the weekly-release Tagging backports for rapid release label Nov 22, 2024
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 32.66%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.68

File Coverage
BrowserViewController.swift 4.71% ⚠️

Generated by 🚫 Danger Swift against 4fe4c4b

@OrlaM OrlaM requested review from OrlaM and removed request for issammani November 26, 2024 15:19
Copy link
Copy Markdown
Contributor

@DonalMe DonalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 133.1

@DonalMe DonalMe merged commit 859d574 into release/v133 Dec 3, 2024
@DonalMe DonalMe deleted the mergify/bp/release/v133/pr-23300 branch December 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

weekly-release Tagging backports for rapid release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants