-
Notifications
You must be signed in to change notification settings - Fork 21
Enable firefox-ci-playground-private to use private artifacts (bug 1989274)
#540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
queue:get-artifact to repos that define an artifact prefix (bug 1989274)
e5d09d0 to
119109e
Compare
e49fcb8 to
3933c6c
Compare
queue:get-artifact to repos that define an artifact prefix (bug 1989274)firefox-ci-playground-private to use private artifacts (bug 1989274)
| if self.trust_project: | ||
| return f"private/{self.trust_domain}-{self.trust_project}" | ||
| else: | ||
| return f"private/{self.trust_domain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this quite matches what was discussed in the first round?
Also, there's some precedent around using "project/foo" as a prefix. Do we want to continue with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed #540 (comment). Please let me know if there's anything I misunderstood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with private/project/foo. Let me know if you prefer project/foo alone. I like private/project/... because it explicitly shows the artifact is private but I don't have a strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find private/project/foo redundant, so I'd rather we picked one, but I'm not going to block on that.
3933c6c to
b283dc3
Compare
b283dc3 to
5a2edb3
Compare
5a2edb3 to
29fc156
Compare
Updated diff after first round of comments: