Experiment: Target new emails.ftl file #989
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dschom
changed the title
dschom
force-pushed
the
new-emails-ftl-file
branch
from
0dc31b4 to
b745c44
Compare
bcolsson
reviewed
Nov 19, 2025
Contributor
bcolsson
left a comment
bcolsson
left a comment
There was a problem hiding this comment.
Thanks for the update, I was going to say we need to preserve the auth.ftl file since there's some strings that will seemingly continue to live in ./fxa-auth-server.
Untested on my end, but I suspect this will extract the strings copied to the libs/accounts/email-renderer folder properly.
Once we have the extraction script working as intended, we'll need to sync on when to merge this PR. We'll want to ensure the following happens in the same window:
- Make sure all strings are up to date by running old migration script and merging, then pausing syncing with Pontoon.
- Merging this workflow change
- Running the extract to create a PR picking up the source strings in the new library
- Running script you mentioned in https://mozilla-hub.atlassian.net/browse/FXA-12597 to copy translations for new strings in
emails.ftlfromauth.ftlfor all locales, (adding those changes to the PR generated in 2, or a new PR after merging 2) - Review and merge string PRs
- Remove duplicate strings from
fxa-auth-server/ run extract script to remove duplicates fromauth.ftl - Re-enable Pontoon sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow us to incorporate the emails.ftl file now that emails rendering has been moved to a shared library. @bcolsson I have tested this yet. The PR is mostly for illustration of what I think would need to change.