Skip to content

Reusable CTA content #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshpensky merged 3 commits into from
Dec 19, 2024
Merged

Reusable CTA content #102

joshpensky merged 3 commits into from
Dec 19, 2024

Conversation

@joshpensky
Copy link
Contributor

@joshpensky joshpensky commented Dec 19, 2024

Changes

  • Adds new CTA post type for reuse
  • Updates CTAs ACF field group to allow pulling content from CTA post
  • Adds new big-cta-row for rendering a row of CTAs
  • Adds new global Discord Invite Link field in site settings

How To Test

  1. Create a new CTA
  2. Update one of the pages to pull from that existing CTA
  3. confirm the content updates accordingly!
  4. Change the discord invite link in site settings to smth obviously wrong
  5. Go to a page with a discord CTA. Confirm it uses the new global link!

@joshpensky joshpensky requested a review from andyrader December 19, 2024 13:16
@joshpensky joshpensky self-assigned this Dec 19, 2024
andyrader
andyrader approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@andyrader andyrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty!

@joshpensky joshpensky merged commit e4d153f into main Dec 19, 2024
1 check passed
@joshpensky joshpensky deleted the feat/reusable-ctas branch December 19, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andyrader andyrader andyrader approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshpensky @andyrader