This repository was archived by the owner on May 22, 2021. It is now read-only.
added L10N_DEV environment variable for making all languages available#314
Merged
dannycoates merged 1 commit intomasterfrom Jul 25, 2017
Merged
added L10N_DEV environment variable for making all languages available#314dannycoates merged 1 commit intomasterfrom
dannycoates merged 1 commit intomasterfrom
Conversation
Contributor
|
sure. does |
Contributor
|
config added, will be present for next deploy to dev |
pdehaan
reviewed
Jul 25, 2017
| partialsDir: 'views/partials/', | ||
| helpers: { | ||
| availableLanguages, | ||
| l10nDev: conf.l10n_dev |
Contributor
There was a problem hiding this comment.
Do we use this helper, or just the availableLanguages helper?
Contributor
Author
There was a problem hiding this comment.
No, I was going to use it to add pontoon.js but the CSP and other changes scared me away for now
Contributor
|
It was a bit tricky to get this running locally. "dev": "npm run build && L10N_DEV=true npm start",Although if we start passing env vars, I think we have to use cross-env so it plays nice w/ Windows. |
Contributor
|
But I'm all 💯 for landing this, as I am seeing a couple issues w/ German when hacking locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #312
@relud can we set
L10N_DEV=truefor send.dev.mozaws.net only?