Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Modify popup delete dialog#327

Merged
dnarcese merged 2 commits intomozilla:masterfrom
youwenliang:ui-refinement
Jul 27, 2017
Merged

Modify popup delete dialog#327
dnarcese merged 2 commits intomozilla:masterfrom
youwenliang:ui-refinement

Conversation

@youwenliang
Copy link
Copy Markdown
Contributor

@youwenliang youwenliang commented Jul 27, 2017

Fixes #326
Also, expand feedback button by default in mobile view since there's no hover state.

public/main.css Outdated
.popup .popuptext::after {
left: auto;
right: 36px;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the popup should move to the left earlier. It causes horizontal scrolling at any screen between widths 768px and 920px.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

fix responsive
@dnarcese dnarcese merged commit 07b9545 into mozilla:master Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants