Add autoprefixer and cssnano support#419
Conversation
| static/* | ||
| !static/info.txt | ||
| test/frontend/bundle.js | ||
| public/main.css |
There was a problem hiding this comment.
I moved the public/main.css file to frontend/src/main.css. Then npm run build:css does the whole autoprefixer, media query combining, minification and source map magic and copies the processed file back into the old public/main.css location.
browserslist
Outdated
| not last 2 Opera versions | ||
| not last 2 OperaMini versions | ||
| not last 2 OperaMobile versions | ||
| not last 2 UCAndroid versions |
There was a problem hiding this comment.
I totally made all this up. LOLOLOL.
| }; | ||
|
|
||
| if (conf.env === 'development') { | ||
| options.map = { inline: true }; |
There was a problem hiding this comment.
I only enabled sourcemaps in dev mode. We can adjust this as much as anybody cares... like maybe we dont want minification on the dev server, etc.
|
@pdehaan can you rebase? LGTM, but what do I know about css 🤷♂️ |
|
Hey @bwinton, mind taking a 👁 as the highest ranking CSS Czar? |
|
Alternatively, we could convert the source to Sass and run scss-lint against the frontend/src/*.scss, and run the stylelint compatibility check only against the compiled autoprefixer vendored output in public/*css. |
bwinton
left a comment
bwinton
left a comment
There was a problem hiding this comment.
Seems fine to me, although there aren't a lot of CSS changes… 🙂 I say ship it.
3 participants
Adds autoprefixer support and cssnano minification.
Fixes #143