Conversation
|
|
||
| document.addEventListener('DOMContentLoaded', function() { | ||
| links = document.querySelectorAll('a:not([target])'); | ||
| links = Array.from(document.querySelectorAll('a:not([target])')); |
There was a problem hiding this comment.
Edge doesn't have forEach on NodeList
| @@ -1,4 +1,4 @@ | |||
| const testPilotGA = require('testpilot-ga'); | |||
| const testPilotGA = require('testpilot-ga/src/TestPilotGA'); | |||
There was a problem hiding this comment.
This is a bit hacky but it lets us transpile the lib how we want to
There was a problem hiding this comment.
It technically works, but only due to a bug in mozilla/testpilot-ga#13.
Not sure how you want to address. We'd either have to re-compile the testpilot-ga dist files, or kill my upstream PR and remove the bad files in testpilot-ga repo.
There was a problem hiding this comment.
we can cross that bridge when we get there ;)
There was a problem hiding this comment.
Totally, just wanted to point out that due to the fact of loose dependency versions ("testpilot-ga": "^0.3.0"), semver, and upstream repos, that could technically break at any point in the future when @chuckharmston publishes a new version of testpilot-ga.
| "babel-polyfill": "^6.23.0", | ||
| "babel-preset-es2015": "^6.24.1", | ||
| "babel-preset-stage-2": "^6.24.1", | ||
| "browserify": "^14.4.0", |
There was a problem hiding this comment.
we should follow up to remove this, but i didn't want to mess with test--browser yet
2 participants
This is just a start at webpack and transpiling to es2015.
@pdehaan I excluded the "env" preset for now for simplicity. We should revisit it along with removing the full polyfill.min.js script from the template in a follow up issue.
Bonus: fixes Edge (I think)