Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Use EXPIRE_SECONDS to calculate file ttl for static content#672

Merged
dannycoates merged 1 commit intomozilla:masterfrom
derektamsen:dynamically-generate-file-ttl
Dec 21, 2017
Merged

Use EXPIRE_SECONDS to calculate file ttl for static content#672
dannycoates merged 1 commit intomozilla:masterfrom
derektamsen:dynamically-generate-file-ttl

Conversation

@derektamsen
Copy link
Copy Markdown
Contributor

This resolves #671

  • Calculate hours from the global variable EXPIRE_SECONDS
  • Use the calculated value to specify the file ttl on the share page

screenshot-2017-12-13 firefox send 1

@dannycoates
Copy link
Copy Markdown
Contributor

this looks good. Thank you @derektamsen 😄

@dannycoates dannycoates merged commit cf5405f into mozilla:master Dec 21, 2017
@derektamsen derektamsen deleted the dynamically-generate-file-ttl branch December 22, 2017 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share page generated with hard coded '24 hours' TTL

2 participants