This repository was archived by the owner on May 22, 2021. It is now read-only.
show download Limits on page; Fixes #661#721
Merged
dannycoates merged 1 commit intomozilla:masterfrom Jan 23, 2018
Merged
Conversation
Contributor
|
Thank you @shikhar-scs, nice job! 😄 |
Contributor
Author
|
Welcome @dannycoates. Thanks to you for not giving up on me and guiding me so far 😄 |
Contributor
|
Congrats, @shikhar-scs. Nice |
flodolo
reviewed
Jan 23, 2018
| // Alternative text used on the download link/button (indicates an action). | ||
| downloadAltText = Download | ||
| downloadsFileList = Downloads | ||
| timeFileList = Time |
Collaborator
There was a problem hiding this comment.
Sorry, I lost track of this PR. This should have a comment, "time" it's a very broad word in English.
Contributor
Author
There was a problem hiding this comment.
This Time refers to this header here
This initially was set as Expires In should I change it back.
Collaborator
There was a problem hiding this comment.
That's really not my call ;-)
In the meantime I opened a PR to add a localization comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR was filed at #681.
However due to some poor rebasing and squashing habits, the final set of commits messed up a bit.
All the fine details and conversations can be followed at #681. This PR can be referred for what was done in the files.
And I am a 100% sure that this only contains the intended changes.
And thus, this would be the final PR.
@dannycoates please review this .
If correct, please close #681
😄