Unpin ecdsa #192
Merged
Unpin ecdsa #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 16 16
Lines 1728 1728
=======================================
Hits 1616 1616
Misses 112 112 Continue to review full report at Codecov.
|
|
Hi @blag, could you review and merge the change? It looks like new version of ecdsa gives some performance boost. |
|
Hello maintainers, can you have a look at this? the new pip resolver will prevent usage of ecdsa 0.16 even if it can be used with python-jose. |
Contributor
|
NAK. Just because the most recent version of ecdsa works for us doesn't mean that 0.15 won't mess things up somehow. We still need to blacklist ecdsa 0.15: |
blag
suggested changes
Nov 19, 2020
blag
added
dependencies
Co-authored-by: blag <[email protected]>
blag
approved these changes
Nov 23, 2020
Contributor
|
Thanks! |
dreid
added a commit
to dreid/python-jose
that referenced
this pull request
Nov 30, 2020
The previous pull request mpdavis#192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a newer version of ecdsa
0.16.0. We can unpin version, because all of tests passed.