"Analyze Data Flow" does not work with the lombok plugin

[npiguet]

Short description

Neither "Analyze data flow from here" nor "Analyze data flow to here" work correctly with the lombok plugin. It behaves as if the analysis was not able to see the code generated by lombok. Basically all field accesses done through lombok generated methods are invisible to the analysis, and that makes this tool completely useless.

Expected behavior

I would expect to see the whole data flow telling me how a field in an @value class is populated, but I only get a single line containing only that field name and none of its usages.

Version information

• IDEA Version: 2019.3 EAP5 (Build #IU-193.4386.10)
• JDK Version: 1.8.0_131-b11
• OS Type & Version: Ubuntu 19.4
• Lombok Plugin Version: 0.27-EAP
• Lombok Dependency Version: 1.18.10

Steps to reproduce

Using the provided sample project:

1. Run "Analyze data flow TO here" on Order.product.

2. Notice how calls to the non-generated constructor are displayed in the hierarchy.

3. Notice how calls to the generated constructor are not displayed

4. Compare the results of running "Analyze data flow FROM here" on Order.product and Order.number

5. Notice how the analysis for Order.number which uses non-generated getters and setters shows calls to the getter

6. Notice how the analysis for Order.product which has @Getter and @Setter does not show any usages.

Sample project

sample.zip

[npiguet]

Further investigation into this points to the fact that the "Dataflow to/from Here" (which is internally called SliceBackwardAction and SliceForwardAction) feature of intellij uses com.intellij.psi.search.searches.ReferencesSearch. This one in turn can be extended by supplying instances of com.intellij.openapi.application.QueryExecutor.

As it turns out, earlier version of the Lombok plugin shipped with an implementation called LombokReferenceSearcher, but that class was removed from the plugin services definition some time last year.

It looks like re-enabling this class and tweaking it to report its results should help with this issue.

[gbastiaan]

Any sight on this being fixed? We cannot work with Lombok now anymore, and even the de-Lombok functionality (on global level) is broken...