Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
added a commit
that referenced
this pull request
Mar 3, 2026
…ing `CxxPart` with `weak_ptr` (#1238) Separates out the C++ reference we hold in Kotlin to a separate `CxxPart` nested class that holds a `weak_ptr` to C++. That way we break the cyclic reference, and avoid a memory leak which can be reproduced in #1239 - Fixes a memory leak that happened with all Kotlin Hybrid Objects: margelo/react-native-vision-camera-v5#143 🥳 - Makes HybridObject initialization a **tiny bit** faster since we no longer call `initHybrid()` multiple times per subclass; now it's overridden and only called once - clean! :) - `JHybridObject` now only has one implementation for `equals(..)`, `toString()`, and `dispose()`, which is virtual in Java - no need for C++ duplicate implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It currently fails on Kotlin - that is expected. Will be fixed by #1238